Bug 160779

Summary: False crashes in fast/text/emoji-gender-* tests
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Major CC: commit-queue, glenn, lforschler, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Jonathan Bedard
Reported 2016-08-11 13:13:56 PDT
Run-webkit-tests is falsely reporting crashes in some tests due to a bug in webkitpy. From radar 27786762.
Attachments
Patch (3.39 KB, patch)
2016-08-11 13:22 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (3.42 KB, patch)
2016-08-11 13:49 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2016-08-11 13:22:59 PDT
Created attachment 285847 [details] Patch
Alexey Proskuryakov
Comment 2 2016-08-11 13:32:40 PDT
Comment on attachment 285847 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285847&action=review Good catch! > Tools/Scripts/webkitpy/port/driver.py:447 > + self._server_process.write('#SAMPLE FINISHED\n', True) # Must be able to ignore a broken pipe here. This comment does not explain why we need to ignore a failure to write. How can it be improved to explain it?
Jonathan Bedard
Comment 3 2016-08-11 13:49:32 PDT
Created attachment 285852 [details] Patch
Alexey Proskuryakov
Comment 4 2016-08-11 14:06:19 PDT
Comment on attachment 285852 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285852&action=review > Tools/Scripts/webkitpy/port/driver.py:447 > + self._server_process.write('#SAMPLE FINISHED\n', True) # Must be able to ignore a broken pipe here, target process may already be closed. A slightly shorter way to say the same is "Ignoring write errors, as target process may already be terminated."
WebKit Commit Bot
Comment 5 2016-08-16 11:05:13 PDT
Comment on attachment 285852 [details] Patch Clearing flags on attachment: 285852 Committed r204514: <http://trac.webkit.org/changeset/204514>
WebKit Commit Bot
Comment 6 2016-08-16 11:05:18 PDT
All reviewed patches have been landed. Closing bug.
Simon Fraser (smfr)
Comment 7 2016-08-16 11:13:58 PDT
I feel like this could have had a better changelog entry. I can't easily tell what the bug was and how you fixed it.
Note You need to log in before you can comment on or make changes to this bug.