Bug 161813

Summary:

[CSS Parser] Add the main parser implementation

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

CSS

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

46591

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	dino: review+, buildbot: commit-queue-
Archive of layout-test-results from ews113 for mac-yosemite	none
Patch to fix failures	none

Dave Hyatt

Reported 2016-09-09 14:06:59 PDT

[CSS Parser] Add the main parser implementation

Attachments
Patch (72.67 KB, patch) 2016-09-09 14:11 PDT, Dave Hyatt	no flags	Details Formatted Diff Diff
Patch (72.66 KB, patch) 2016-09-09 14:17 PDT, Dave Hyatt	no flags	Details Formatted Diff Diff
Patch (72.65 KB, patch) 2016-09-09 14:26 PDT, Dave Hyatt	dino: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews113 for mac-yosemite (741.16 KB, application/zip) 2016-09-09 14:58 PDT, Build Bot	no flags	Details
Patch to fix failures (73.23 KB, patch) 2016-09-09 17:35 PDT, Dave Hyatt	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Dave Hyatt

Comment 1 2016-09-09 14:11:13 PDT

Created attachment 288437 [details] Patch Patch

WebKit Commit Bot

Comment 2 2016-09-09 14:13:02 PDT

Attachment 288437 [details] did not pass style-queue: ERROR: Source/WebCore/css/parser/CSSParserImpl.cpp:59: Wrong number of spaces before statement. (expected: 4) [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/CSSParserImpl.cpp:60: Wrong number of spaces before statement. (expected: 4) [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/CSSParserImpl.cpp:61: Wrong number of spaces before statement. (expected: 4) [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/CSSParserImpl.cpp:112: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WebCore/css/parser/CSSParserImpl.cpp:99: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebCore/css/parser/CSSParserImpl.cpp:228: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/CSSParserImpl.cpp:237: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/CSSParserImpl.cpp:242: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WebCore/css/parser/CSSParserImpl.cpp:602: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/CSSParserImpl.cpp:665: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WebCore/css/parser/CSSParserImpl.cpp:805: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebCore/css/StyleRule.cpp:410: Wrong number of spaces before statement. (expected: 4) [whitespace/indent] [4] ERROR: Source/WebCore/css/parser/CSSSupportsParser.h:48: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 13 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Dave Hyatt

Comment 3 2016-09-09 14:17:46 PDT

Created attachment 288439 [details] Patch

WebKit Commit Bot

Comment 4 2016-09-09 14:20:36 PDT

Attachment 288439 [details] did not pass style-queue: ERROR: Source/WebCore/css/parser/CSSParserImpl.cpp:99: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebCore/css/StyleRule.cpp:410: Wrong number of spaces before statement. (expected: 4) [whitespace/indent] [4] Total errors found: 2 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Dave Hyatt

Comment 5 2016-09-09 14:26:58 PDT

Created attachment 288441 [details] Patch

Dean Jackson

Comment 6 2016-09-09 14:40:12 PDT

Comment on attachment 288441 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288441&action=review There are a bunch of // comments that are not ending with punctuation. > Source/WebCore/css/parser/CSSPropertyParser.cpp:246 > + /* Could you put a FIXME here?

Build Bot

Comment 7 2016-09-09 14:58:31 PDT

Comment on attachment 288441 [details] Patch Attachment 288441 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2043497 Number of test failures exceeded the failure limit.

Build Bot

Comment 8 2016-09-09 14:58:34 PDT

Created attachment 288444 [details] Archive of layout-test-results from ews113 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5

Dave Hyatt

Comment 9 2016-09-09 17:35:55 PDT

Created attachment 288457 [details] Patch to fix failures

Dave Hyatt

Comment 10 2016-09-11 11:14:10 PDT

Landed in r205790.

Note You need to log in before you can comment on or make changes to this bug.