Bug 161868

Summary:

[CSS Parser] Add support for the parsing of the HTML sizes attribute

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

CSS

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

46591

Attachments:

Description	Flags
Patch	none
Patch	dino: review+, buildbot: commit-queue-
Archive of layout-test-results from ews122 for ios-simulator-elcapitan-wk2	none

Dave Hyatt

Reported 2016-09-12 12:13:50 PDT

[CSS Parser] Add support for the parsing of the HTML sizes attribute.

Attachments
Patch (30.94 KB, patch) 2016-09-12 12:16 PDT, Dave Hyatt	no flags	Details Formatted Diff Diff
Patch (30.95 KB, patch) 2016-09-12 12:21 PDT, Dave Hyatt	dino: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews122 for ios-simulator-elcapitan-wk2 (deleted) 2016-09-12 13:54 PDT, Build Bot	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Dave Hyatt

Comment 1 2016-09-12 12:16:05 PDT

Created attachment 288597 [details] Patch

WebKit Commit Bot

Comment 2 2016-09-12 12:18:46 PDT

Attachment 288597 [details] did not pass style-queue: ERROR: Source/WebCore/css/parser/SizesAttributeParser.h:49: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/css/parser/SizesCalcParser.cpp:231: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/css/parser/SizesCalcParser.cpp:245: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/css/parser/SizesCalcParser.cpp:247: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebCore/css/parser/SizesAttributeParser.cpp:33: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 5 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Dave Hyatt

Comment 3 2016-09-12 12:21:22 PDT

Created attachment 288600 [details] Patch

Dean Jackson

Comment 4 2016-09-12 12:32:49 PDT

Comment on attachment 288600 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288600&action=review > Source/WebCore/css/parser/SizesAttributeParser.cpp:51 > + if (type == CSSPrimitiveValue::CSS_EXS || type == CSSPrimitiveValue::CSS_CHS) { Why not CSS_EMS too? > Source/WebCore/css/parser/SizesAttributeParser.cpp:104 > + // A Media Condition cannot have a media type other then screen. Typo: than

Build Bot

Comment 5 2016-09-12 13:54:01 PDT

Comment on attachment 288600 [details] Patch Attachment 288600 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2060905 New failing tests: fast/scrolling/ios/scrollTo-at-page-load.html

Build Bot

Comment 6 2016-09-12 13:54:05 PDT

Created attachment 288607 [details] Archive of layout-test-results from ews122 for ios-simulator-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-elcapitan-wk2 Platform: Mac OS X 10.11.5

Dave Hyatt

Comment 7 2016-09-12 14:15:03 PDT

Landed in r205821.

Note You need to log in before you can comment on or make changes to this bug.