Bug 161931

Summary: [CSS Parser] Enable the new sizes parser by default
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: CSSAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ryanhaddad
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 46591    
Attachments:
Description Flags
Patch
none
Patch zalan: review+

Dave Hyatt
Reported 2016-09-13 15:27:16 PDT
[CSS Parser] Enable the new sizes parser by default
Attachments
Patch (33.62 KB, patch)
2016-09-13 15:28 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (146.84 KB, patch)
2016-09-14 08:46 PDT, Dave Hyatt 		zalan: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2016-09-13 15:28:47 PDT
Created attachment 288738 [details] Patch
WebKit Commit Bot
Comment 2 2016-09-13 15:30:30 PDT
Attachment 288738 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 3 2016-09-14 08:46:05 PDT
Created attachment 288820 [details] Patch
Dave Hyatt
Comment 4 2016-09-14 08:57:16 PDT
Landed in r205905.
Ryan Haddad
Comment 5 2016-09-14 09:43:46 PDT
The tests added with this change are failing on iOS-simulator https://build.webkit.org/results/Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/r205905%20(14)/results.html
Ryan Haddad
Comment 6 2016-09-14 09:58:10 PDT
(In reply to comment #5) > The tests added with this change are failing on iOS-simulator > > https://build.webkit.org/results/ > Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/r205905%20(14)/ > results.html I went ahead and rebaselined the the tests for ios-simulator in http://trac.webkit.org/projects/webkit/changeset/205911 Please let me know / revert the change if this is incorrect.
Note You need to log in before you can comment on or make changes to this bug.