Bug 163249

Summary: [mac] LayoutTest media/modern-media-controls/play-pause-button/play-pause-button.html is a flaky failure
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, graouts, graouts
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=163248
Attachments:
Description Flags
Patch
none
Patch for landing none

Ryan Haddad
Reported 2016-10-10 15:39:34 PDT
LayoutTest media/modern-media-controls/play-pause-button/play-pause-button.html is a flaky failure https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r207023%20(449)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fplay-pause-button%2Fplay-pause-button.html --- /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/media/modern-media-controls/play-pause-button/play-pause-button-expected.txt +++ /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/media/modern-media-controls/play-pause-button/play-pause-button-actual.txt @@ -10,12 +10,12 @@ PASS playButton.playing is false PASS pauseButton.playing is true PASS pauseButton.iconName is "pause" -PASS playButton.element.style.webkitMaskImage.includes("macOS/play@") is true +FAIL playButton.element.style.webkitMaskImage.includes("macOS/play@") should be true. Was false. PASS pauseButton.element.style.webkitMaskImage.includes("macOS/pause@") is true -PASS iOSPlayButton.element.style.webkitMaskImage.includes("iOS/play@") is true -PASS iOSPauseButton.element.style.webkitMaskImage.includes("iOS/pause@") is true -PASS fullscreenPlayButton.element.style.webkitMaskImage.includes("macOS/play-fullscreen@") is true -PASS fullscreenPauseButton.element.style.webkitMaskImage.includes("macOS/pause-fullscreen@") is true +FAIL iOSPlayButton.element.style.webkitMaskImage.includes("iOS/play@") should be true. Was false. +FAIL iOSPauseButton.element.style.webkitMaskImage.includes("iOS/pause@") should be true. Was false. +FAIL fullscreenPlayButton.element.style.webkitMaskImage.includes("macOS/play-fullscreen@") should be true. Was false. +FAIL fullscreenPauseButton.element.style.webkitMaskImage.includes("macOS/pause-fullscreen@") should be true. Was false. PASS successfullyParsed is true TEST COMPLETE
Attachments
Patch (2.50 KB, patch)
2016-10-11 06:38 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.47 KB, patch)
2016-10-11 07:25 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2016-10-10 15:40:09 PDT
Test was added with https://trac.webkit.org/changeset/207015
Antoine Quint
Comment 2 2016-10-11 06:38:52 PDT
Created attachment 291254 [details] Patch
WebKit Commit Bot
Comment 3 2016-10-11 07:20:52 PDT
Comment on attachment 291254 [details] Patch Rejecting attachment 291254 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 291254, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: reset by peer M LayoutTests/media/modern-media-controls/airplay-button/airplay-button.html M LayoutTests/ChangeLog M LayoutTests/TestExpectations r207135 = ecf248e570d658ebd2f61e5e69cce8fa02f89afd (refs/remotes/origin/master) M Source/WebCore/platform/spi/win/CoreTextSPIWin.h M Source/WebCore/ChangeLog r207136 = 75998878933c335ec15213b2750a714a2d8f4f3e (refs/remotes/origin/master) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/2262436
Antoine Quint
Comment 4 2016-10-11 07:25:08 PDT
Created attachment 291255 [details] Patch for landing
WebKit Commit Bot
Comment 5 2016-10-11 08:00:30 PDT
Comment on attachment 291255 [details] Patch for landing Clearing flags on attachment: 291255 Committed r207138: <http://trac.webkit.org/changeset/207138>
WebKit Commit Bot
Comment 6 2016-10-11 08:00:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.