Bug 165168

Summary: [Cocoa] Pass the embedding app's bundle ID to new instances of NEFilterSource
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cdumez, commit-queue, enrica, rniwa, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Andy Estes
Reported 2016-11-29 15:50:05 PST
[Cocoa] Pass the embedding app's bundle ID to new instances of NEFilterSource
Attachments
Patch (5.11 KB, patch)
2016-11-29 15:55 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (5.14 KB, patch)
2016-11-29 15:56 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (5.19 KB, patch)
2016-11-30 09:17 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2016-11-29 15:51:15 PST
<rdar://problem/29003618>
Andy Estes
Comment 2 2016-11-29 15:55:27 PST
Created attachment 295657 [details] Patch
Andy Estes
Comment 3 2016-11-29 15:56:02 PST
Created attachment 295658 [details] Patch
Simon Fraser (smfr)
Comment 4 2016-11-29 16:58:33 PST
Comment on attachment 295658 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295658&action=review > Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm:78 > + // FIXME: Remove the -respondsToSelector: check once -setSourceAppBundleID: is in an SDK. Is there a radar tracking that? Better to cite the radar. > Source/WebCore/platform/spi/cocoa/NEFilterSourceSPI.h:83 > +// FIXME: Confine this to the !USE(APPLE_INTERNAL_SDK) section once this is defined in an SDK. Also cite the radar.
Andy Estes
Comment 5 2016-11-30 09:09:07 PST
(In reply to comment #4) > Comment on attachment 295658 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=295658&action=review > > > Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm:78 > > + // FIXME: Remove the -respondsToSelector: check once -setSourceAppBundleID: is in an SDK. > > Is there a radar tracking that? Better to cite the radar. > > > Source/WebCore/platform/spi/cocoa/NEFilterSourceSPI.h:83 > > +// FIXME: Confine this to the !USE(APPLE_INTERNAL_SDK) section once this is defined in an SDK. > > Also cite the radar. There is a Radar, and I'll cite it. Thanks for the review!
Andy Estes
Comment 6 2016-11-30 09:17:13 PST
Created attachment 295722 [details] Patch
WebKit Commit Bot
Comment 7 2016-11-30 12:07:15 PST
The commit-queue encountered the following flaky tests while processing attachment 295722 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2016-11-30 12:07:50 PST
The commit-queue encountered the following flaky tests while processing attachment 295722 [details]: transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 9 2016-11-30 12:34:39 PST
Comment on attachment 295722 [details] Patch Clearing flags on attachment: 295722 Committed r209147: <http://trac.webkit.org/changeset/209147>
WebKit Commit Bot
Comment 10 2016-11-30 12:34:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.