Bug 165816

Summary: Add a PerfTest targeting IDBObjectStore.get()
Product: WebKit Reporter: Brady Eidson <beidson>
Component: Tools / TestsAssignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, lforschler, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 160306    
Attachments:
Description Flags
Patch none

Brady Eidson
Reported 2016-12-13 12:21:29 PST
Add a PerfTest targeting IDBObjectStore.get()
Attachments
Patch (2.84 KB, patch)
2016-12-13 12:22 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2016-12-13 12:22:14 PST
Created attachment 297033 [details] Patch
Daniel Bates
Comment 2 2016-12-13 12:24:27 PST
Comment on attachment 297033 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297033&action=review > PerformanceTests/IndexedDB/objectstore-get.html:41 > +function *runIteration() I'm surprised that star in front of runIterations does not cause a syntax error.
Daniel Bates
Comment 3 2016-12-13 12:27:09 PST
(In reply to comment #2) > Comment on attachment 297033 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=297033&action=review > > > PerformanceTests/IndexedDB/objectstore-get.html:41 > > +function *runIteration() > > I'm surprised that star in front of runIterations does not cause a syntax > error. Disregard this remark. function* is the syntax to define a generator,<https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/function*>
WebKit Commit Bot
Comment 4 2016-12-13 12:42:16 PST
Comment on attachment 297033 [details] Patch Clearing flags on attachment: 297033 Committed r209772: <http://trac.webkit.org/changeset/209772>
WebKit Commit Bot
Comment 5 2016-12-13 12:42:21 PST
All reviewed patches have been landed. Closing bug.
Brady Eidson
Comment 6 2016-12-13 12:51:04 PST
(In reply to comment #3) > (In reply to comment #2) > > Comment on attachment 297033 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=297033&action=review > > > > > PerformanceTests/IndexedDB/objectstore-get.html:41 > > > +function *runIteration() > > > > I'm surprised that star in front of runIterations does not cause a syntax > > error. > > Disregard this remark. function* is the syntax to define a > generator,<https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/ > Statements/function*> Yup - Because of how asynchronous IndexedDB is, we've fallen into the pattern of function generators to right linear tests for it. :)
Brady Eidson
Comment 7 2016-12-13 12:51:51 PST
(In reply to comment #6) > (In reply to comment #3) > > (In reply to comment #2) > > > Comment on attachment 297033 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=297033&action=review > > > > > > > PerformanceTests/IndexedDB/objectstore-get.html:41 > > > > +function *runIteration() > > > > > > I'm surprised that star in front of runIterations does not cause a syntax > > > error. > > > > Disregard this remark. function* is the syntax to define a > > generator,<https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/ > > Statements/function*> > > Yup - Because of how asynchronous IndexedDB is, we've fallen into the > pattern of function generators to right linear tests for it. :) Wow. To say that again: Yup - Because of how asynchronous IndexedDB is, we've fallen into the pattern of *using* function generators to *write* linear tests for it.
Note You need to log in before you can comment on or make changes to this bug.