Bug 168672

Summary: WebAssembly: support 0x1 version
Product: WebKit Reporter: JF Bastien <jfbastien>
Component: JavaScriptCoreAssignee: JF Bastien <jfbastien>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, jfbastien, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 159775, 168784, 168788    
Attachments:
Description Flags
patch
none
patch none

JF Bastien
Reported 2017-02-21 13:46:21 PST
Other engines are moving to 0x1, so is tooling. We should do the same. IIUC it's just a renumbering.
Attachments
patch (1.96 MB, patch)
2017-02-23 10:25 PST, JF Bastien 		no flags
DetailsFormatted DiffDiff
patch (1.96 MB, patch)
2017-02-23 11:05 PST, JF Bastien 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
JF Bastien
Comment 1 2017-02-23 10:25:38 PST
Created attachment 302529 [details] patch
WebKit Commit Bot
Comment 2 2017-02-23 10:28:20 PST
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".
Keith Miller
Comment 3 2017-02-23 11:00:38 PST
I think we should continue to accept 0xD for now, in addition to 0x1. Otherwise, we will probably break some other tests.
JF Bastien
Comment 4 2017-02-23 11:05:11 PST
Created attachment 302542 [details] patch Also support 0xD for now. Removal tracked by bug #168788.
Keith Miller
Comment 5 2017-02-23 11:09:53 PST
r=me on the code/json changes. I'm just going to rubber stamp the test changes.
WebKit Commit Bot
Comment 6 2017-02-23 13:38:05 PST
Comment on attachment 302542 [details] patch Clearing flags on attachment: 302542 Committed r212922: <http://trac.webkit.org/changeset/212922>
WebKit Commit Bot
Comment 7 2017-02-23 13:38:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.