Bug 169511

Summary:

devtools: optional dark UI theme

Product:

WebKit

Reporter:

Vitaly Zdanevich <zdanevich.vitaly>

Component:

Web Inspector

Assignee:

Matt Baker <mattbaker>

Status:

NEW

Severity:

Normal

CC:

bburg, chris, hello, inspector-bugzilla-changes, joepeck, mattbaker

Priority:

Version:

WebKit Local Build

Hardware:

All

OS:

All

Bug Depends on:

166993

Bug Blocks:

186308

Attachments:

Description	Flags
[Image] Original settings UI	none
[Image] New settings UI	none

Vitaly Zdanevich

Reported 2017-03-11 01:32:50 PST

Chromium and Firefox have build-in dark themes, it is convenient for night environment and easier for sensitive eyes.

Attachments
[Image] Original settings UI (250.81 KB, image/png) 2017-03-21 23:58 PDT, Matt Baker	no flags	Details
[Image] New settings UI (237.26 KB, image/png) 2017-03-22 00:00 PDT, Matt Baker	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Blaze Burg

Comment 1 2017-03-19 13:36:45 PDT

*** Bug 169864 has been marked as a duplicate of this bug. ***

Matt Baker

Comment 2 2017-03-21 23:58:29 PDT Comment hidden (obsolete)

Created attachment 305081 [details] [Image] Original settings UI

Matt Baker

Comment 3 2017-03-22 00:00:39 PDT Comment hidden (obsolete)

Created attachment 305082 [details] [Image] New settings UI Preparatory UI changes for supporting multiple settings "pages". Patch will introduce new view classes: - SettingsPage - GeneralSettingsPage - ThemeSettingsPage Styles have been updated to more closely match Xcode.

Blaze Burg

Comment 4 2017-03-22 11:29:22 PDT Comment hidden (obsolete)

(In reply to Matt Baker from comment #3) > Created attachment 305082 [details] > [Image] New settings UI > > Preparatory UI changes for supporting multiple settings "pages". Patch will > introduce new view classes: > > - SettingsPage > - GeneralSettingsPage > - ThemeSettingsPage > > Styles have been updated to more closely match Xcode. This is great work, but I think this bug is inappropriate for the work. Can you move it to https://bugs.webkit.org/show_bug.cgi?id=166993 or make a new refactor bug?

Blaze Burg

Comment 5 2017-03-22 11:29:40 PDT

for the /bug/*

Craig

Comment 6 2018-02-23 11:59:37 PST

I was about to file an enhancement for Safari's Web Inspector dark UI theme (as it exists on Chrome/Firefox as Vitaly said including the comment for night/sensitive eyes). Timothy Hatcher (@xeenon) suggested I should write in! It is a great feature and to continue the macOS dark menu bar and Dock theme trend :-)

Chris Chiera

Comment 7 2018-06-04 19:46:24 PDT

As many of us expected a dark theme was delayed a few years for Safari/Webkit presumably because Apple wanted to announced a more OS level dark mode all at once. With that now officially announced, and a dark theme available now in Safari and X Code my concern is that unlike Chrome and others the theme is only available in MacOS dark mode presumably. White text on black screens everywhere in an OS of course can be a bit of an accessibility nightmare and poor for long term vision, but night modes/themes in certain apps is wonderful such as coding especially where the font is colored rather than white. So curious how we will be able to have a dark theme in Safari without having to enable OS level dark modes. Does Webkit plan to now offer a dark theme? Also where the OS level mode presumably does not allow you install themes using css like Chrome, will Webkit?

Blaze Burg

Comment 8 2018-06-05 09:25:03 PDT

Hi Chris, (In reply to Chris Chiera from comment #7) > So curious how we will be able to have a dark theme in Safari without having > to enable OS level dark modes. Does Webkit plan to now offer a dark theme? > Also where the OS level mode presumably does not allow you install themes > using css like Chrome, will Webkit? The Web Inspector changes for dark theme (i.e, what you can see in the MacOS Mojave seed) will be posted to the WebKit repository in the coming few weeks. At that time, we can decide in what ways it should be usable. Right now, it is hardcoded to follow the system appearance. I don't foresee any problems making it possible to opt in just Web Inspector, but it hasn't been implemented yet.

Note You need to log in before you can comment on or make changes to this bug.