Bug 172621

Summary: Web Inspector: Don't create NavigationSidebarPanel classes until they are needed by a Tab
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, timothy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 172393    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
timothy: review+
Patch none

Devin Rousso
Reported 2017-05-25 16:21:40 PDT
Currently, each of these classes are constructed when the related TabContentView is constructed, which all happen when the TabBrowser loads the open tabs from settings. Instead, they should only be created once a tab that requires it is shown.
Attachments
Patch (10.55 KB, patch)
2017-05-25 16:33 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (10.85 KB, patch)
2017-05-25 18:35 PDT, Devin Rousso 		timothy: review+
DetailsFormatted DiffDiff
Patch (10.92 KB, patch)
2017-06-02 20:06 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2017-05-25 16:33:11 PDT
Created attachment 311314 [details] Patch
Devin Rousso
Comment 2 2017-05-25 18:35:07 PDT
Created attachment 311323 [details] Patch
Timothy Hatcher
Comment 3 2017-06-02 10:09:02 PDT
Comment on attachment 311323 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311323&action=review Looks good. > Source/WebInspectorUI/UserInterface/Views/TabContentView.js:182 > get navigationSidebarCollapsedSetting() { return this._navigationSidebarCollapsedSetting; } Add a new line above since the new getter is not a single line.
Devin Rousso
Comment 4 2017-06-02 20:06:34 PDT
Created attachment 311901 [details] Patch
WebKit Commit Bot
Comment 5 2017-06-02 20:44:55 PDT
Comment on attachment 311901 [details] Patch Clearing flags on attachment: 311901 Committed r217750: <http://trac.webkit.org/changeset/217750>
WebKit Commit Bot
Comment 6 2017-06-02 20:44:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.