Bug 177408

Summary: Remove SetterMayThrowException
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2017-09-23 10:51:28 PDT
It is no longer needed. Might also change a little bit AttributeSetter to not make it a template class anymore, since this is somehow redundant with the Functor parameter of its call method.
Attachments
Patch (131.84 KB, patch)
2017-09-23 10:57 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-09-23 10:57:36 PDT
Created attachment 321634 [details] Patch
Build Bot
Comment 2 2017-09-23 10:59:54 PDT
Attachment 321634 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSDOMAttribute.h:96: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 65 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2017-09-23 19:38:11 PDT
Comment on attachment 321634 [details] Patch Clearing flags on attachment: 321634 Committed r222429: <http://trac.webkit.org/changeset/222429>
WebKit Commit Bot
Comment 4 2017-09-23 19:38:13 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-09-27 12:20:49 PDT
<rdar://problem/34693096>
Note You need to log in before you can comment on or make changes to this bug.