Bug 178609

Summary:

[Payment Request] Resolve PaymentRequest.show()'s accept promise when a payment is authorized

Product:

WebKit

Reporter:

Andy Estes <aestes>

Component:

New Bugs

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, beidson, buildbot, cdumez, commit-queue, esprehn+autocc, kondapallykalyan, sam, thorton, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

174796

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Andy Estes

Reported 2017-10-20 16:52:41 PDT

[Payment Request] Resolve PaymentRequest.show()'s accept promise when a payment is authorized

Attachments
Patch (91.54 KB, patch) 2017-10-20 17:00 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (95.99 KB, patch) 2017-10-23 12:29 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (94.51 KB, patch) 2017-10-23 13:24 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Andy Estes

Comment 1 2017-10-20 17:00:38 PDT

Created attachment 324468 [details] Patch

Build Bot

Comment 2 2017-10-20 17:03:07 PDT Comment hidden (obsolete)

Attachment 324468 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:74: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 41 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alex Christensen

Comment 3 2017-10-23 09:49:00 PDT

Comment on attachment 324468 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324468&action=review > Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:287 > + auto address = PaymentAddress::create(); > + address->setCountry(contact.countryCode); Could we make a constructor that takes these values so if we add one later we won't forget to add setters in all the necessary places? > Source/WebCore/Modules/paymentrequest/PaymentAddress.h:38 > + static Ref<PaymentAddress> create() Yeah, let's add a meaningful constructor instead of a bunch of setters.

Andy Estes

Comment 4 2017-10-23 12:29:38 PDT Comment hidden (obsolete)

Created attachment 324576 [details] Patch

Andy Estes

Comment 5 2017-10-23 12:30:31 PDT

rdar://problem/33542813

WebKit Commit Bot

Comment 6 2017-10-23 12:33:14 PDT Comment hidden (obsolete)

Comment on attachment 324576 [details] Patch Rejecting attachment 324576 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 324576, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: file LayoutTests/http/tests/paymentrequest/payment-response-payerName-attribute.https.html patching file LayoutTests/http/tests/paymentrequest/payment-response-payerPhone-attribute.https-expected.txt patching file LayoutTests/http/tests/paymentrequest/payment-response-payerPhone-attribute.https.html patching file LayoutTests/http/tests/paymentrequest/resources/helpers.js Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/4960745

Andy Estes

Comment 7 2017-10-23 13:24:11 PDT

Created attachment 324582 [details] Patch

WebKit Commit Bot

Comment 8 2017-10-23 14:00:50 PDT

Comment on attachment 324582 [details] Patch Clearing flags on attachment: 324582 Committed r223855: <https://trac.webkit.org/changeset/223855>

WebKit Commit Bot

Comment 9 2017-10-23 14:00:52 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.