Bug 182412

Summary: Form submission after navigation fails when decidePolicyForNavigationAction is async
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, beidson, cdumez, commit-queue, dbates, ews-watchlist, japhet, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=180568
Bug Depends on: 182697    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews102 for mac-sierra
none
Archive of layout-test-results from ews113 for mac-sierra
none
Patch
none
Archive of layout-test-results from ews103 for mac-sierra
none
Archive of layout-test-results from ews112 for mac-sierra
none
Patch none

Alex Christensen
Reported 2018-02-01 16:43:00 PST
Form submission after navigation fails when decidePolicyForNavigationAction is async
Attachments
Patch (2.87 KB, patch)
2018-02-01 16:44 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (5.58 KB, patch)
2018-02-02 14:18 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-sierra (368.35 KB, application/zip)
2018-02-02 14:59 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews113 for mac-sierra (380.47 KB, application/zip)
2018-02-02 15:09 PST, EWS Watchlist 		no flags
Details
Patch (8.57 KB, patch)
2018-02-02 15:15 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-sierra (498.56 KB, application/zip)
2018-02-02 15:42 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews112 for mac-sierra (1.25 MB, application/zip)
2018-02-02 15:56 PST, EWS Watchlist 		no flags
Details
Patch (5.12 KB, patch)
2018-02-08 13:59 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-02-01 16:44:08 PST
Created attachment 332923 [details] Patch
Alex Christensen
Comment 2 2018-02-01 16:44:44 PST
Comment on attachment 332923 [details] Patch Initial patch just contains failing test for rdar://problem/35181099
Alex Christensen
Comment 3 2018-02-02 14:18:12 PST
Created attachment 333000 [details] Patch
Brady Eidson
Comment 4 2018-02-02 14:28:33 PST
Comment on attachment 333000 [details] Patch As discussed in person, this still has changed WK API behavior.
EWS Watchlist
Comment 5 2018-02-02 14:58:59 PST
Comment on attachment 333000 [details] Patch Attachment 333000 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6337129 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 6 2018-02-02 14:59:00 PST
Created attachment 333005 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 7 2018-02-02 15:09:25 PST
Comment on attachment 333000 [details] Patch Attachment 333000 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6337119 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 8 2018-02-02 15:09:26 PST
Created attachment 333007 [details] Archive of layout-test-results from ews113 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6
Alex Christensen
Comment 9 2018-02-02 15:15:17 PST
Created attachment 333009 [details] Patch
EWS Watchlist
Comment 10 2018-02-02 15:42:14 PST
Comment on attachment 333009 [details] Patch Attachment 333009 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6337744 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 11 2018-02-02 15:42:15 PST
Created attachment 333010 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 12 2018-02-02 15:56:20 PST
Comment on attachment 333009 [details] Patch Attachment 333009 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6337743 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 13 2018-02-02 15:56:21 PST
Created attachment 333013 [details] Archive of layout-test-results from ews112 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6
Alex Christensen
Comment 14 2018-02-08 12:57:26 PST
Chris, the three WPT test failures in my latest patch are definitely related to why this bug is happening. If you make TestController::decidePolicyForNavigationAction always dispatch on the run loop, you'll be able to investigate them. I think fixing this will take adding a queue of some sort to the FrameLoader.
Chris Dumez
Comment 15 2018-02-08 13:58:29 PST
<rdar://problem/35181099>
Chris Dumez
Comment 16 2018-02-08 13:59:09 PST
Created attachment 333421 [details] Patch
Chris Dumez
Comment 17 2018-02-08 13:59:43 PST
Seems to pass the tests locally and fix the bug. Let's see how EWS likes it.
Chris Dumez
Comment 18 2018-02-08 14:59:50 PST
Comment on attachment 333421 [details] Patch API tests locally look happy. Mac-EWS as well.
WebKit Commit Bot
Comment 19 2018-02-08 15:49:21 PST
Comment on attachment 333421 [details] Patch Clearing flags on attachment: 333421 Committed r228299: <https://trac.webkit.org/changeset/228299>
WebKit Commit Bot
Comment 20 2018-02-08 15:49:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.