Bug 183679

Summary: WebKit.RestoreSessionStateContainingScrollRestorationDefault API test is failing with async policy delegates
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 180568    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2018-03-15 14:45:59 PDT
WebKit.RestoreSessionStateContainingScrollRestorationDefault API test is failing with async policy delegates.
Attachments
Patch (22.32 KB, patch)
2018-03-15 15:06 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (22.28 KB, patch)
2018-03-15 16:45 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (22.29 KB, patch)
2018-03-16 08:51 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (24.08 KB, patch)
2018-03-16 09:54 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-03-15 15:06:03 PDT
Created attachment 335890 [details] Patch
Chris Dumez
Comment 2 2018-03-15 16:45:57 PDT
Created attachment 335910 [details] Patch
Alex Christensen
Comment 3 2018-03-16 08:28:51 PDT
Comment on attachment 335910 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335910&action=review > Source/WebCore/loader/cache/CachedRawResource.cpp:161 > + auto responseProcessedHandler = [this, protectedThis = CachedResourceHandle<CachedRawResource>(this), client] { To make MSVC happy, replace "protectedThis = CachedResourceHandle<CachedRawResource>(this)" with "protectedThis = WTFMove(protectedThis)". MSVC thinks "this" refers to the containing lambda sometimes.
Chris Dumez
Comment 4 2018-03-16 08:51:22 PDT
Created attachment 335939 [details] Patch
Chris Dumez
Comment 5 2018-03-16 09:54:32 PDT
Created attachment 335945 [details] Patch
Chris Dumez
Comment 6 2018-03-16 11:33:53 PDT
Comment on attachment 335945 [details] Patch Clearing flags on attachment: 335945 Committed r229675: <https://trac.webkit.org/changeset/229675>
Chris Dumez
Comment 7 2018-03-16 11:33:54 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-03-16 11:34:24 PDT
<rdar://problem/38552016>
Note You need to log in before you can comment on or make changes to this bug.