Bug 185505

Summary: REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: WebKit Misc.Assignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP patch
none
Patch none

Fujii Hironori
Reported 2018-05-09 23:32:32 PDT
REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged Windows port crashes soon since Bug 184996. > WebKit.dll!WebView::notifyPreferencesChanged(IWebNotification * notification) Line 5201 C++ > WebKit.dll!WebView::onNotify(IWebNotification * notification) Line 5072 C++ > WebKit.dll!WebNotificationCenter::postNotificationInternal(IWebNotification * notification, wchar_t * notificationName, IUnknown * anObject) Line 131 C++ > WebKit.dll!WebNotificationCenter::postNotificationName(wchar_t * notificationName, IUnknown * anObject, IPropertyBag * userInfo) Line 181 C++ > WebKit.dll!WebPreferences::postPreferencesChangesNotification() Line 148 C++ > WebKit.dll!WebView::initWithFrame(tagRECT frame, wchar_t * frameName, wchar_t * groupName) Line 3164 C++ > MiniBrowserLib.dll!MiniBrowser::prepareViews(HWND__ * mainWnd, const tagRECT & clientRect, HWND__ * & viewHwnd) Line 183 C++ > MiniBrowserLib.dll!MiniBrowser::MiniBrowser(HWND__ * mainWnd, HWND__ * urlBarWnd, bool useLayeredWebView, bool pageLoadTesting) Line 140 C++ > [External Code] > MiniBrowserLib.dll!BrowserWindow::{ctor}::__l2::<lambda>(HWND__ * mainWnd, HWND__ * urlBarWnd, bool useLayeredWebView, bool pageLoadTesting) Line 111 C++ > MiniBrowserLib.dll!std::unique_ptr<ContentWindow,std::default_delete<ContentWindow> > <lambda>(HWND__ *, HWND__ *, bool, bool)::<lambda_invoker_cdecl>(HWND__ * mainWnd, HWND__ * urlBarWnd, bool useLayeredWebView, bool pageLoadTesting) Line 112 C++ > MiniBrowserLib.dll!BrowserWindow::BrowserWindow(int nCmdShow, bool usesLayeredWebView, bool pageLoadTesting, _bstr_t requestedURL, bool useWK2) Line 120 C++ > MiniBrowserLib.dll!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 75 C++ > MiniBrowserLib.dll!dllLauncherEntryPoint(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 109 C++ > MiniBrowser.exe!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 251 C++ > [External Code]
Attachments
WIP patch (1.26 KB, patch)
2018-05-09 23:37 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (2.35 KB, patch)
2018-05-10 00:08 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2018-05-09 23:37:14 PDT
Created attachment 340073 [details] WIP patch
Fujii Hironori
Comment 2 2018-05-10 00:08:16 PDT
Created attachment 340076 [details] Patch
Fujii Hironori
Comment 3 2018-05-10 00:16:44 PDT
Committed r231635: <https://trac.webkit.org/changeset/231635>
Radar WebKit Bug Importer
Comment 4 2018-05-10 00:17:20 PDT
<rdar://problem/40120805>
Chris Dumez
Comment 5 2018-05-10 13:51:00 PDT
Comment on attachment 340076 [details] Patch Thanks for fixing!
Note You need to log in before you can comment on or make changes to this bug.