Bug 189648

Summary: WebFullScreenManager triggers document leaks
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: ap, jeremyj-wk, jer.noble, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 186214    

Simon Fraser (smfr)
Reported 2018-09-15 11:30:10 PDT
Forked from bug 189437: Here's some logging for running media/modern-media-controls/css/webkit-cursor-visibility-auto-hide.html twice in a row: WebFullScreenManager 0x6d22a3540 ctor WebFullScreenManager 0x6d22a3540 enterFullScreenForElement(0x6cb000990) WebFullScreenManager 0x6d22a3540 willEnterFullScreen() - element 0x6cb000990 Testing that control are shown in fullscreen when the controls attribute is not present. PASS media.webkitDisplayingFullscreen is false PASS media.webkitDisplayingFullscreen is true WebFullScreenManager 0x6d22a3540 enterFullScreenForElement(0x6cf000990) WebFullScreenManager 0x6d22a3540 willEnterFullScreen() - element 0x6cf000990 Testing that control are shown in fullscreen when the controls attribute is not present. PASS media.webkitDisplayingFullscreen is false PASS media.webkitDisplayingFullscreen is true
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-09-15 11:30:50 PDT
<rdar://problem/44490412>
Simon Fraser (smfr)
Comment 2 2018-09-16 18:15:41 PDT
WebFrameLoaderClient::dispatchDidStartProvisionalLoad() should close the fullscreen when WTR navigates to about:blank. Not sure why that doesn't work.
Simon Fraser (smfr)
Comment 3 2018-09-16 20:00:15 PDT
Here's the problem: WebFullScreenManager 0x6e9c7ad90 enterFullScreenForElement(0x6e3000990) WebFullScreenManager 0x6e9c7ad90 willEnterFullScreen() - element 0x6e3000990 Document 0x6e1c02570 fullScreenElementRemoved() - fullscreen element 0x6e3000990 [ Test completes] WebFullScreenManager 0x6e9c7ad90 didEnterFullScreen() - element 0x6e3000990 fullScreenElementRemoved() is called between will and didEnterFullscreen.
Note You need to log in before you can comment on or make changes to this bug.