Bug 190494

Summary: Add Houdini specs to features.json
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: WebCore Misc.Assignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, ews-watchlist, joepeck, mmaxfield, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Build fix
none
Fix none

Don Olmstead
Reported 2018-10-11 15:08:05 PDT
Add the rest of the houdini specifications that are still being developed and group them together.
Attachments
Patch (4.21 KB, patch)
2018-10-11 15:13 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (4.19 KB, patch)
2018-10-11 15:21 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Build fix (3.98 KB, patch)
2018-10-11 18:48 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Fix (3.98 KB, patch)
2018-10-11 18:53 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2018-10-11 15:13:01 PDT
Created attachment 352089 [details] Patch
EWS Watchlist
Comment 2 2018-10-11 15:17:32 PDT
Attachment 352089 [details] did not pass style-queue: ERROR: Source/WebCore/features.json:0: The specifications should be sorted alphabetically by name, "HTML5" appears after "Houdini". [json/syntax] [5] ERROR: Source/WebCore/features.json:0: The feature "Worklets Level 1" has a specification field but no specification of that name exists. [json/syntax] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Don Olmstead
Comment 3 2018-10-11 15:21:09 PDT
Created attachment 352090 [details] Patch
WebKit Commit Bot
Comment 4 2018-10-11 17:08:46 PDT
Comment on attachment 352090 [details] Patch Clearing flags on attachment: 352090 Committed r237057: <https://trac.webkit.org/changeset/237057>
WebKit Commit Bot
Comment 5 2018-10-11 17:08:48 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-10-11 17:09:35 PDT
<rdar://problem/45211879>
Don Olmstead
Comment 7 2018-10-11 18:48:43 PDT
Created attachment 352119 [details] Build fix
Don Olmstead
Comment 8 2018-10-11 18:53:01 PDT
Features site isn't parsing the file due to a specification being in a specification.
Don Olmstead
Comment 9 2018-10-11 18:53:36 PDT
Created attachment 352121 [details] Fix
WebKit Commit Bot
Comment 10 2018-10-11 19:44:41 PDT
The commit-queue encountered the following flaky tests while processing attachment 352121 [details]: compositing/geometry/limit-layer-bounds-opacity-transition.html bug 190507 (authors: danakj@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 11 2018-10-11 19:45:33 PDT
Comment on attachment 352121 [details] Fix Clearing flags on attachment: 352121 Committed r237062: <https://trac.webkit.org/changeset/237062>
WebKit Commit Bot
Comment 12 2018-10-11 19:45:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.