Bug 190788

Summary: Remove non-standard -webkit-margin-collapse CSS property and longhands
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: CSSAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hi, ikilpatrick, joepeck, koivisto, kondapallykalyan, macpherson, menard, ntim, pangle, pdr, rego, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=104944
Bug Depends on:    
Bug Blocks: 234692    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
simon.fraser: review+
Patch none

Simon Fraser (smfr)
Reported 2018-10-22 01:45:51 PDT
-webkit-margin-collpase is a non-standard extension added in https://trac.webkit.org/changeset/7362/webkit. I wonder if we can remove it.
Attachments
Patch (100.48 KB, patch)
2021-12-24 07:06 PST, Tim Nguyen (:ntim) 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (105.45 KB, patch)
2021-12-24 07:57 PST, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Patch (113.95 KB, patch)
2021-12-24 09:22 PST, Tim Nguyen (:ntim) 		simon.fraser: review+
DetailsFormatted DiffDiff
Patch (113.93 KB, patch)
2021-12-24 10:33 PST, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2018-10-22 04:23:16 PDT
There's a mention here: https://stackoverflow.com/questions/11046596/collapsing-margin-on-legend-tag Chrome usage counting: https://www.chromestatus.com/metrics/css/timeline/popularity/269 This probably over-counts, according to Ian K.
Manuel Rego Casasnovas
Comment 2 2019-12-11 05:28:09 PST
*** Bug 204956 has been marked as a duplicate of this bug. ***
Manuel Rego Casasnovas
Comment 3 2019-12-11 05:29:09 PST
Just for future reference, this is the comment from ikilpatrick@ on the duplicated bug: Blink is going to attempt to remove this in the M81 release, see: https://bugs.chromium.org/p/chromium/issues/detail?id=1030765 https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/ewWQH9vEqtI/L2r2WFhPBAAJ
Tim Nguyen (:ntim)
Comment 4 2021-12-24 07:06:53 PST
Created attachment 447936 [details] Patch
Tim Nguyen (:ntim)
Comment 5 2021-12-24 07:57:29 PST
Created attachment 447939 [details] Patch
Tim Nguyen (:ntim)
Comment 6 2021-12-24 09:22:41 PST
Created attachment 447943 [details] Patch
Tim Nguyen (:ntim)
Comment 7 2021-12-24 10:06:19 PST
Comment on attachment 447943 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447943&action=review > LayoutTests/ChangeLog:3 > + Rqa"§emove non-standard -webkit-margin-collapse CSS property and longhands nit: fix commit message here
Tim Nguyen (:ntim)
Comment 8 2021-12-24 10:33:07 PST
Created attachment 447944 [details] Patch
Tim Nguyen (:ntim)
Comment 9 2021-12-24 10:55:50 PST
Committed r287429 (245564@trunk): <https://commits.webkit.org/245564@trunk>
Radar WebKit Bug Importer
Comment 10 2021-12-24 10:56:22 PST
<rdar://problem/86895519>
Note You need to log in before you can comment on or make changes to this bug.