Bug 191770

Summary: Web Inspector: Remove parameters from TreeOutline SelectionDidChange event
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 191483    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Archive of layout-test-results from ews126 for ios-simulator-wk2
none
Patch for landing none

Matt Baker
Reported 2018-11-16 13:57:05 PST
Summary: Remove parameters from TreeOutline SelectionDidChange event. Current the event data includes {selectedElement, deselectedElement}. In a world where TreeOutline can have multiple selected items, these properties don't make sense. Let's remove them and let the handler decide what to do. `selectedElement` is redundant; the handler can just ask for `event.target.selectedTreeElement`. `deselectedElement` is only used in one place, and can be avoided easily.
Attachments
Patch (13.07 KB, patch)
2018-11-16 14:01 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
Patch (14.98 KB, patch)
2018-11-16 14:52 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
Patch for landing (15.10 KB, patch)
2018-11-21 17:17 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.53 MB, application/zip)
2018-11-21 20:17 PST, EWS Watchlist 		no flags
Details
Patch for landing (15.10 KB, patch)
2018-11-25 13:05 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2018-11-16 14:01:08 PST
Created attachment 355116 [details] Patch
Matt Baker
Comment 2 2018-11-16 14:52:53 PST
Created attachment 355131 [details] Patch
Radar WebKit Bug Importer
Comment 3 2018-11-16 14:53:18 PST
<rdar://problem/46140601>
Devin Rousso
Comment 4 2018-11-20 21:23:42 PST
Comment on attachment 355131 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355131&action=review r=me, nice cleanup :) Rather than use `event.target.selectedTreeElement`, it seems like most of these cases could refer to the actual member `WI.TreeOutline` object (e.g. CallFrameTreeController.js could use `this._treeOutline.selectedTreeElement` instead, or most of the `WI.NavigationSidebarPanel` subclasses could use `this.contentTreeOutline` instead) > Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js:845 > + let selectedTreeElement = event.target.selectedTreeElement; NIT: I'd move this to be right above the `if` that checks for it's existence (down one line)
Matt Baker
Comment 5 2018-11-21 17:17:55 PST
Created attachment 355447 [details] Patch for landing
EWS Watchlist
Comment 6 2018-11-21 20:17:05 PST
Comment on attachment 355447 [details] Patch for landing Attachment 355447 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10105201 New failing tests: media/no-fullscreen-when-hidden.html
EWS Watchlist
Comment 7 2018-11-21 20:17:07 PST
Created attachment 355460 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Matt Baker
Comment 8 2018-11-25 13:05:11 PST
Created attachment 355602 [details] Patch for landing
WebKit Commit Bot
Comment 9 2018-11-25 13:44:53 PST
Comment on attachment 355602 [details] Patch for landing Clearing flags on attachment: 355602 Committed r238483: <https://trac.webkit.org/changeset/238483>
WebKit Commit Bot
Comment 10 2018-11-25 13:44:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.