Bug 191865

Summary: [css-scroll-snap] scroll-snap-align parsing is incorrect/backwards
Product: WebKit Reporter: Majid Valipour <majidvp>
Component: CSSAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, m.goleb+bugzilla, mrobinson, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: BrowserCompat, InRadar
Version: Safari 12   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 218115    
Attachments:
Description Flags
Patch
none
Patch none

Majid Valipour
Reported 2018-11-20 12:58:58 PST
CSSWG has resolved [1] to change the ordering of scroll-snap-align property to be in "block inline" order. WebKit parsing logic appear to do "inline, block" order. I have changed Chromium implementation to match the specification but it is now different from Safari. The current usage of two value is low but as it grows the interop issue problem grows. Additional links: - My backward compat analysis suggested the risk is low [2] - Relevant WPT test [3]. I tested this on Safari 12.0.1. [1] https://github.com/w3c/csswg-drafts/issues/2232 [2] https://github.com/w3c/csswg-drafts/issues/2232#issuecomment-399961633 [3] https://wpt.fyi/results/css/css-scroll-snap/snap-inline-block.html?label=stable&aligned
Attachments
Patch (12.43 KB, patch)
2021-01-13 08:47 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (14.54 KB, patch)
2021-01-14 01:37 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-11-29 10:35:08 PST
<rdar://problem/46346516>
Martin Robinson
Comment 2 2021-01-13 08:47:11 PST
Created attachment 417539 [details] Patch
Simon Fraser (smfr)
Comment 3 2021-01-13 09:42:35 PST
Comment on attachment 417539 [details] Patch Please fix the failing test.
Martin Robinson
Comment 4 2021-01-14 01:37:47 PST
Created attachment 417604 [details] Patch
EWS
Comment 5 2021-01-14 03:02:47 PST
Committed r271480: <https://trac.webkit.org/changeset/271480> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417604 [details].
Note You need to log in before you can comment on or make changes to this bug.