Bug 192160

Summary: webkitpy: Use DeviceType instead of str to represent device class
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, dbates, ews-watchlist, glenn, lforschler, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 192257    
Attachments:
Description Flags
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2018-11-29 09:45:34 PST
Using a string to represent device class has a number of deficiencies, especially when we just convert this string to a DeviceType to connect/spawn devices anyways. We should start with the DeviceType to begin with.
Attachments
Patch (23.02 KB, patch)
2018-11-29 16:21 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (22.99 KB, patch)
2018-11-30 10:45 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-11-29 09:46:29 PST
<rdar://problem/46344845>
Jonathan Bedard
Comment 2 2018-11-29 16:21:47 PST
Created attachment 356084 [details] Patch
Aakash Jain
Comment 3 2018-11-30 10:01:30 PST
rs=me
Jonathan Bedard
Comment 4 2018-11-30 10:45:11 PST
Created attachment 356198 [details] Patch for landing
WebKit Commit Bot
Comment 5 2018-11-30 11:34:01 PST
The commit-queue encountered the following flaky tests while processing attachment 356198 [details]: inspector/audit/basic.html bug 192237 (author: drousso@apple.com) webgl/2.0.0/conformance/more/conformance/quickCheckAPI-B1.html bug 192238 (author: justin_fan@apple.com) inspector/dom-debugger/event-animation-frame-breakpoints.html bug 192221 (author: drousso@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2018-11-30 11:34:16 PST
The commit-queue encountered the following flaky tests while processing attachment 356198 [details]: inspector/layers/layer-tree-manager.html bug 192239 (authors: drousso@apple.com and ross.kirsling@sony.com) workers/bomb.html bug 171985 (author: fpizlo@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2018-11-30 12:13:25 PST
Comment on attachment 356198 [details] Patch for landing Clearing flags on attachment: 356198 Committed r238749: <https://trac.webkit.org/changeset/238749>
WebKit Commit Bot
Comment 8 2018-11-30 12:13:27 PST
All reviewed patches have been landed. Closing bug.
Daniel Bates
Comment 9 2018-11-30 14:41:55 PST
(In reply to WebKit Commit Bot from comment #7) > Comment on attachment 356198 [details] > Patch for landing > > Clearing flags on attachment: 356198 > > Committed r238749: <https://trac.webkit.org/changeset/238749> This broke run-api-tests for iOS Simulator. See bug #192257.
Jonathan Bedard
Comment 10 2018-11-30 15:24:42 PST
(In reply to Daniel Bates from comment #9) > (In reply to WebKit Commit Bot from comment #7) > > Comment on attachment 356198 [details] > > Patch for landing > > > > Clearing flags on attachment: 356198 > > > > Committed r238749: <https://trac.webkit.org/changeset/238749> > > This broke run-api-tests for iOS Simulator. See bug #192257. Thanks for the heads up...totally forgot that script used this too, fixing now.
Note You need to log in before you can comment on or make changes to this bug.