Bug 192257

Summary: REGRESSION (r238749): run-api-tests dies with AttributeError: 'IOSSimulatorPort' object has no attribute 'DEFAULT_DEVICE_CLASS'
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, glenn, lforschler, slewis, webkit-bug-importer
Priority: P1 Keywords: InRadar, Regression
Version: WebKit Local Build   
Hardware: iPhone / iPad   
OS: iOS 12   
Bug Depends on: 192160    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Daniel Bates
Reported 2018-11-30 14:41:19 PST
Ran `run-api-tests --debug --ios-simulator`. It dies with the following error: AttributeError: 'IOSSimulatorPort' object has no attribute 'DEFAULT_DEVICE_CLASS': [[ $ Tools/Scripts/run-api-tests --debug --ios-simulator --no-build Checking build ... AttributeError raised: 'IOSSimulatorPort' object has no attribute 'DEFAULT_DEVICE_CLASS' Traceback (most recent call last): File "/Volumes/.../OpenSource/Tools/Scripts/webkitpy/api_tests/run_api_tests.py", line 58, in main return run(port, options, args, stderr) File "/Volumes/.../OpenSource/Tools/Scripts/webkitpy/api_tests/run_api_tests.py", line 76, in run result = manager.run(args, json_output=options.json_output) File "/Volumes/.../OpenSource/Tools/Scripts/webkitpy/api_tests/manager.py", line 163, in run self._initialize_devices() File "/Volumes/.../OpenSource/Tools/Scripts/webkitpy/api_tests/manager.py", line 132, in _initialize_devices SimulatedDeviceManager.initialize_devices(DeviceRequest(DeviceType.from_string(self._port.DEFAULT_DEVICE_CLASS), allow_incomplete_match=True), self.host, simulator_ui=False) AttributeError: 'IOSSimulatorPort' object has no attribute 'DEFAULT_DEVICE_CLASS' ]]
Attachments
Patch (1.99 KB, patch)
2018-11-30 15:37 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-11-30 14:41:53 PST
<rdar://problem/46384671>
Radar WebKit Bug Importer
Comment 2 2018-11-30 14:41:53 PST
<rdar://problem/46384673>
Jonathan Bedard
Comment 3 2018-11-30 15:37:16 PST
Created attachment 356251 [details] Patch
WebKit Commit Bot
Comment 4 2018-11-30 16:26:09 PST
Comment on attachment 356251 [details] Patch Clearing flags on attachment: 356251 Committed r238763: <https://trac.webkit.org/changeset/238763>
WebKit Commit Bot
Comment 5 2018-11-30 16:26:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.