Bug 192756

Summary: [LFC][BFC][MarginCollapsing] BlockFormattingState should cache the maximum positive and negative margin values for margin collapsing.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: NEW    
Severity: Normal CC: ahmad.saleem792, bfulgham, koivisto, simon.fraser, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 215087    
Attachments:
Description Flags
Patch koivisto: review+

alan
Reported 2018-12-17 08:00:15 PST
When two or more margins collapse, the resulting margin width is the maximum of the collapsing margins' widths. In the case of negative margins, the maximum of the absolute values of the negative adjoining margins is deducted from the maximum of the positive adjoining margins. If there are no positive margins, the maximum of the absolute values of the adjoining margins is deducted from zero.
Attachments
Patch (2.54 KB, patch)
2018-12-17 08:05 PST, alan 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2018-12-17 08:05:42 PST
Created attachment 357440 [details] Patch
Ahmad Saleem
Comment 2 2022-10-10 09:58:43 PDT
I checked with BugID on Webkit GitHub and it seems this r+ patch didn't landed. Thanks!
Note You need to log in before you can comment on or make changes to this bug.