Bug 192897

Summary: [iOS] Interpret text key commands on keydown and app key commands on keypress
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: iPhone / iPad   
OS: iOS 12   
See Also: https://bugs.webkit.org/show_bug.cgi?id=192898
Bug Depends on:    
Bug Blocks: 190571, 193679    
Attachments:
Description Flags
Patch
none
Layout test (once we fix bug #192898)
none
To Land none

Daniel Bates
Reported 2018-12-19 16:34:57 PST
To match Mac, we should interpret text key commands (e.g. Control + A) on keydown and app key commands (e.g. Command + F in Safari) on keypress.
Attachments
Patch (7.40 KB, patch)
2018-12-19 16:51 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Layout test (once we fix bug #192898) (2.50 KB, text/html)
2018-12-19 16:52 PST, Daniel Bates 		no flags
Details
To Land (8.16 KB, patch)
2019-01-08 17:00 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-12-19 16:35:21 PST
<rdar://problem/46857378>
Daniel Bates
Comment 2 2018-12-19 16:51:28 PST
Created attachment 357755 [details] Patch I did not include a test for this change since we need to fix bug #192898 in order to support testing Control-modified key commands. Will upload a test that we can use once bug #192898 is fixed. We no longer need to check that we are interpreting a keydown event before calling the SPI as the SPI does this check for us.
Daniel Bates
Comment 3 2018-12-19 16:52:11 PST
Created attachment 357756 [details] Layout test (once we fix bug #192898)
Daniel Bates
Comment 4 2018-12-19 16:54:23 PST
Comment on attachment 357756 [details] Layout test (once we fix bug #192898) This layout test was written with the assumption that it would be placed in LayoutTests/fast/events/ios (or at least in a similar directory hierarchy).
Brent Fulgham
Comment 5 2019-01-04 12:55:23 PST
Comment on attachment 357755 [details] Patch Looks good. Do we need any UIKit changes to support this before landing?
Daniel Bates
Comment 6 2019-01-07 16:14:39 PST
(In reply to Brent Fulgham from comment #5) > Comment on attachment 357755 [details] > Patch > > Looks good. Do we need any UIKit changes to support this before landing? Yes, we need the fix for <rdar://problem/46854373>.
Daniel Bates
Comment 7 2019-01-08 17:00:17 PST
Created attachment 358656 [details] To Land
Daniel Bates
Comment 8 2019-01-16 19:01:47 PST
*** Bug 191768 has been marked as a duplicate of this bug. ***
Daniel Bates
Comment 9 2019-01-22 12:59:56 PST
Comment on attachment 358656 [details] To Land Clearing flags on attachment: 358656 Committed r240285: <https://trac.webkit.org/changeset/240285>
Daniel Bates
Comment 10 2019-01-22 12:59:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.