Bug 193649

Summary: Move delegatesScrolling() tests to lower level conversion function in ScrollView
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, fred.wang, kangil.han, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=182785
Attachments:
Description Flags
patch
none
patch none

Antti Koivisto
Reported 2019-01-21 01:45:04 PST
They should be in viewToContents/contentsToView functions.
Attachments
patch (9.94 KB, patch)
2019-01-21 01:52 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (8.23 KB, patch)
2019-01-21 02:14 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2019-01-21 01:52:51 PST
Created attachment 359678 [details] patch
Antti Koivisto
Comment 2 2019-01-21 02:14:58 PST
Created attachment 359679 [details] patch
Frédéric Wang (:fredw)
Comment 3 2019-01-21 03:04:28 PST
Comment on attachment 359679 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=359679&action=review This LGTMs, thanks! > Source/WebCore/platform/ScrollView.cpp:-864 > - This is reverting what was added in bug 186956. I guess your patch is the right way to fix it. > Source/WebCore/platform/ScrollView.cpp:-877 > - I'm curious if this will fix bug 184297 as the patch I uploaded there does similar thing.
Antti Koivisto
Comment 4 2019-01-21 03:45:45 PST
Comment on attachment 359679 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=359679&action=review >> Source/WebCore/platform/ScrollView.cpp:-864 >> - > > This is reverting what was added in bug 186956. I guess your patch is the right way to fix it. Yeah, the result should be the same.
WebKit Commit Bot
Comment 5 2019-01-21 04:27:58 PST
Comment on attachment 359679 [details] patch Clearing flags on attachment: 359679 Committed r240232: <https://trac.webkit.org/changeset/240232>
WebKit Commit Bot
Comment 6 2019-01-21 04:28:00 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-01-21 04:28:29 PST
<rdar://problem/47427108>
Note You need to log in before you can comment on or make changes to this bug.