Bug 194576

Summary: generateUnlinkedCodeBlockForFunctions shouldn't need to create a FunctionExecutable just to get its source code
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Tadeu Zagallo <tzagallo>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 194575    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Saam Barati
Reported 2019-02-12 17:53:29 PST
...
Attachments
Patch (5.84 KB, patch)
2019-02-13 08:22 PST, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.85 KB, patch)
2019-02-14 09:32 PST, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.85 KB, patch)
2019-02-14 09:35 PST, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-02-12 20:11:36 PST
Nice
Tadeu Zagallo
Comment 2 2019-02-13 08:22:42 PST
Created attachment 361919 [details] Patch
Saam Barati
Comment 3 2019-02-13 12:19:08 PST
Comment on attachment 361919 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361919&action=review r=me > Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.h:117 > + SourceCode linkedSourceCode(const SourceCode&); nit: I think this function can be marked const?
Tadeu Zagallo
Comment 4 2019-02-14 09:32:45 PST
Created attachment 362027 [details] Patch for landing
WebKit Commit Bot
Comment 5 2019-02-14 09:33:44 PST
Comment on attachment 362027 [details] Patch for landing Rejecting attachment 362027 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 362027, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/JavaScriptCore/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/11147914
Tadeu Zagallo
Comment 6 2019-02-14 09:35:21 PST
Created attachment 362029 [details] Patch for landing
WebKit Commit Bot
Comment 7 2019-02-14 10:12:33 PST
Comment on attachment 362029 [details] Patch for landing Clearing flags on attachment: 362029 Committed r241552: <https://trac.webkit.org/changeset/241552>
WebKit Commit Bot
Comment 8 2019-02-14 10:12:35 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-02-14 10:13:34 PST
<rdar://problem/48078104>
Note You need to log in before you can comment on or make changes to this bug.