Bug 194598

Summary: [EWS] status bubble should show Failed to apply when a patch doesn't apply on any EWS queue
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: ASSIGNED    
Severity: Normal CC: aakash_jain, ap, dbates, jbedard, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 197522    
Bug Blocks:    
Attachments:
Description Flags
WIP none

Aakash Jain
Reported 2019-02-13 10:45:10 PST
status bubble generated by ews-app should show Failed to apply when a patch doesn't apply on any EWS queue.
Attachments
WIP (2.24 KB, patch)
2019-07-21 17:44 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-07-21 17:44:43 PDT
Created attachment 374584 [details] WIP
Aakash Jain
Comment 2 2019-07-21 17:46:52 PDT
Need to design a webpage which will open on clicking the 'patch does not apply to trunk of repository' button.
Jonathan Bedard
Comment 3 2019-07-22 07:54:41 PDT
Comment on attachment 374584 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=374584&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:238 > + failed_to_apply = all(map(lambda bubble: "failed_to_apply" in bubble or bubble['state'] == 'none', bubbles)) Shouldn't this be: bubble.get('failed_to_apply') since "bubble['failed_to_apply'] = False" seems perfectly valid.
Radar WebKit Bug Importer
Comment 4 2019-07-24 10:58:41 PDT
<rdar://problem/53503951>
Aakash Jain
Comment 5 2019-08-27 09:35:48 PDT
*** Bug 201184 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.