Bug 195610

Summary: Move the remaining code to decide whether site specific quirks are needed to Quirks class
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, ggaren, jer.noble, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Cleanup
none
Patch for landing none

Ryosuke Niwa
Reported 2019-03-12 00:26:19 PDT
Move the remaining logic to decide whether a site specific quirk is needed or not to Quirks class.
Attachments
Cleanup (13.58 KB, patch)
2019-03-12 00:31 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch for landing (13.58 KB, patch)
2019-03-12 04:11 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2019-03-12 00:31:58 PDT
Created attachment 364364 [details] Cleanup
Antti Koivisto
Comment 2 2019-03-12 01:31:30 PDT
Comment on attachment 364364 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=364364&action=review > Source/WebCore/page/Quirks.cpp:80 > +bool Quirks::needsAutoplayPlayPauseEventsQuirk() const The second 'Quirk' is redundant.
Ryosuke Niwa
Comment 3 2019-03-12 04:10:52 PDT
(In reply to Antti Koivisto from comment #2) > Comment on attachment 364364 [details] > Cleanup > > View in context: > https://bugs.webkit.org/attachment.cgi?id=364364&action=review > > > Source/WebCore/page/Quirks.cpp:80 > > +bool Quirks::needsAutoplayPlayPauseEventsQuirk() const > > The second 'Quirk' is redundant. Fixed.
Ryosuke Niwa
Comment 4 2019-03-12 04:11:27 PDT
Created attachment 364376 [details] Patch for landing
WebKit Commit Bot
Comment 5 2019-03-12 04:38:17 PDT
The commit-queue encountered the following flaky tests while processing attachment 364376 [details]: legacy-animation-engine/cssom/cssvalue-comparison.html bug 195617 (authors: dino@apple.com and graouts@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2019-03-12 04:38:56 PDT
Comment on attachment 364376 [details] Patch for landing Clearing flags on attachment: 364376 Committed r242792: <https://trac.webkit.org/changeset/242792>
WebKit Commit Bot
Comment 7 2019-03-12 04:38:58 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-03-12 04:39:16 PDT
<rdar://problem/48804436>
Note You need to log in before you can comment on or make changes to this bug.