Bug 196084

Summary: Remove the SVG tear off objects for SVGNumber, SVGNumberList and SVGAnimatedNumberList
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: SVGAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, ews-watchlist, jonlee, rniwa, simon.fraser, thorton, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 195905    
Bug Blocks: 191237    
Attachments:
Description Flags
Patch
none
Patch for review
none
Patch
none
Patch
none
Archive of layout-test-results from ews107 for mac-highsierra-wk2 none

Said Abou-Hallawa
Reported 2019-03-21 10:15:46 PDT
This is part of removing the tear off objects of the SVG properties.
Attachments
Patch (150.04 KB, patch)
2019-03-21 13:52 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch for review (66.82 KB, patch)
2019-03-21 13:54 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (65.26 KB, patch)
2019-03-21 17:15 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (66.04 KB, patch)
2019-03-21 17:50 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews107 for mac-highsierra-wk2 (2.99 MB, application/zip)
2019-03-21 20:28 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2019-03-21 13:52:32 PDT
Created attachment 365609 [details] Patch
Radar WebKit Bug Importer
Comment 2 2019-03-21 13:53:41 PDT
<rdar://problem/49122470>
Said Abou-Hallawa
Comment 3 2019-03-21 13:54:16 PDT
Created attachment 365610 [details] Patch for review
Said Abou-Hallawa
Comment 4 2019-03-21 17:15:39 PDT
Created attachment 365650 [details] Patch
Simon Fraser (smfr)
Comment 5 2019-03-21 17:38:26 PDT
Comment on attachment 365650 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365650&action=review > Source/WebCore/svg/properties/SVGAnimationAdditiveListFunctionImpl.h:58 > + const Vector<Ref<SVGNumber>>& fromItems = m_animationMode == AnimationMode::To ? animated->items() : m_from->items(); > + const Vector<Ref<SVGNumber>>& toItems = m_to->items(); > + const Vector<Ref<SVGNumber>>& toAtEndOfDurationItems = toAtEndOfDuration()->items(); auto?
Said Abou-Hallawa
Comment 6 2019-03-21 17:50:51 PDT
Created attachment 365656 [details] Patch
EWS Watchlist
Comment 7 2019-03-21 20:28:57 PDT
Comment on attachment 365656 [details] Patch Attachment 365656 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11608462 New failing tests: imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html
EWS Watchlist
Comment 8 2019-03-21 20:28:58 PDT
Created attachment 365672 [details] Archive of layout-test-results from ews107 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
WebKit Commit Bot
Comment 9 2019-03-21 21:45:32 PDT
Comment on attachment 365656 [details] Patch Clearing flags on attachment: 365656 Committed r243362: <https://trac.webkit.org/changeset/243362>
WebKit Commit Bot
Comment 10 2019-03-21 21:45:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.