Bug 199313

Summary:

LayoutTests svg/clip-path/clip-hidpi.svg isn't working as expected due to a syntax error

Product:

WebKit

Reporter:

Fujii Hironori <fujii.hironori>

Component:

Tools / Tests

Assignee:

Fujii Hironori <fujii.hironori>

Status:

REOPENED

Severity:

Normal

CC:

cgarcia, ews-watchlist, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=198746

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-highsierra	none
Archive of layout-test-results from ews112 for mac-highsierra	none
Patch	none

Fujii Hironori

Reported 2019-06-28 00:22:43 PDT

LayoutTests svg/clip-path/clip-hidpi.svg isn't working as expected due to a syntax error This syntax error was created by me in Bug 198746 Comment 18.

Attachments
Patch (1.30 KB, patch) 2019-06-28 00:26 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-highsierra (3.22 MB, application/zip) 2019-06-28 01:33 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews112 for mac-highsierra (3.12 MB, application/zip) 2019-06-28 02:13 PDT, EWS Watchlist	no flags	Details
Patch (2.54 KB, patch) 2019-06-28 03:29 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Fujii Hironori

Comment 1 2019-06-28 00:26:20 PDT

Created attachment 373092 [details] Patch

EWS Watchlist

Comment 2 2019-06-28 01:33:18 PDT

Comment on attachment 373092 [details] Patch Attachment 373092 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12600916 New failing tests: svg/clip-path/clip-hidpi.svg

EWS Watchlist

Comment 3 2019-06-28 01:33:20 PDT

Created attachment 373096 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 4 2019-06-28 02:13:00 PDT

Comment on attachment 373092 [details] Patch Attachment 373092 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12600943 New failing tests: svg/clip-path/clip-hidpi.svg

EWS Watchlist

Comment 5 2019-06-28 02:13:02 PDT

Created attachment 373098 [details] Archive of layout-test-results from ews112 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6

Fujii Hironori

Comment 6 2019-06-28 03:07:17 PDT

clip-hidpi-stderr.txt > ImageDiff produced stderr output: > Error: test and reference images have different sizes. Test image is 1600x1200, reference image is 800x600 > ImageDiff crashed

Fujii Hironori

Comment 7 2019-06-28 03:29:43 PDT

Created attachment 373102 [details] Patch

Fujii Hironori

Comment 8 2019-06-30 19:31:07 PDT

Comment on attachment 373102 [details] Patch Clearing flags on attachment: 373102 Committed r246959: <https://trac.webkit.org/changeset/246959>

Fujii Hironori

Comment 9 2019-06-30 19:31:10 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 10 2019-06-30 19:32:18 PDT

<rdar://problem/52435665>

Fujii Hironori

Comment 11 2019-06-30 20:59:50 PDT

Oh, no. mac-wk2-ews reported it is flaky (Bug 198323 comment 13). I'm going to revert. > Unexpected flakiness: image-only failures (1) > svg/clip-path/clip-hidpi.svg [ ImageOnlyFailure Pass ]

Fujii Hironori

Comment 12 2019-06-30 21:04:10 PDT

Reverted r246959 for reason: svg/clip-path/clip-hidpi.svg is flaky on mac-wk2-ews Committed r246961: <https://trac.webkit.org/changeset/246961>

Note You need to log in before you can comment on or make changes to this bug.