Bug 199344

Summary:

RenderObject::absoluteClippedOverflowRect() should not be affected by whether composited scrolling is enabled

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

clord, ews-watchlist, rniwa, simon.fraser, thorton, zalan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=226007

Attachments:

Description	Flags
Patch, needs tests	none
Patch	none
Archive of layout-test-results from ews103 for mac-highsierra	none
Archive of layout-test-results from ews106 for mac-highsierra-wk2	none
Archive of layout-test-results from ews113 for mac-highsierra	none
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews100 for mac-highsierra	none
Archive of layout-test-results from ews106 for mac-highsierra-wk2	none
Archive of layout-test-results from ews113 for mac-highsierra	none
patch	none

Simon Fraser (smfr)

Reported 2019-06-29 16:23:38 PDT

RenderObject::absoluteClippedOverflowRect() should not be affected by whether composited scrolling is enabled

Attachments
Patch, needs tests (71.42 KB, patch) 2019-06-29 16:32 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (74.24 KB, patch) 2019-07-01 15:10 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-highsierra (3.58 MB, application/zip) 2019-07-01 16:02 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (3.12 MB, application/zip) 2019-07-01 16:31 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews113 for mac-highsierra (2.99 MB, application/zip) 2019-07-01 17:09 PDT, EWS Watchlist	no flags	Details
Patch (74.81 KB, patch) 2019-07-01 17:11 PDT, Tim Horton	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-highsierra (3.20 MB, application/zip) 2019-07-01 18:24 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.71 MB, application/zip) 2019-07-01 18:33 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews113 for mac-highsierra (3.28 MB, application/zip) 2019-07-01 18:46 PDT, EWS Watchlist	no flags	Details
patch (74.79 KB, patch) 2019-07-01 18:58 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2019-06-29 16:32:54 PDT

Created attachment 373179 [details] Patch, needs tests

EWS Watchlist

Comment 2 2019-06-29 16:46:14 PDT Comment hidden (obsolete)

Attachment 373179 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderInline.cpp:913: Extra space before ) [whitespace/parens] [2] Total errors found: 1 in 40 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 3 2019-07-01 15:10:08 PDT

Created attachment 373273 [details] Patch

Tim Horton

Comment 4 2019-07-01 15:11:03 PDT Comment hidden (obsolete)

Comment on attachment 373273 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373273&action=review > LayoutTests/fast/text/mark-matches-overflow-clip-async-scrolling-expected.txt:2 > +Before scrolling: marker rects: Before this change, there was a rect here that was outside the bounds of the `overflow: scroll` element.

EWS Watchlist

Comment 5 2019-07-01 16:02:29 PDT Comment hidden (obsolete)

Comment on attachment 373273 [details] Patch Attachment 373273 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12632056 New failing tests: fast/text/mark-matches-overflow-clip-async-scrolling.html

EWS Watchlist

Comment 6 2019-07-01 16:02:31 PDT Comment hidden (obsolete)

Created attachment 373276 [details] Archive of layout-test-results from ews103 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 7 2019-07-01 16:31:05 PDT Comment hidden (obsolete)

Comment on attachment 373273 [details] Patch Attachment 373273 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12632229 New failing tests: fast/text/mark-matches-overflow-clip-async-scrolling.html

EWS Watchlist

Comment 8 2019-07-01 16:31:07 PDT Comment hidden (obsolete)

Created attachment 373277 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 9 2019-07-01 17:09:57 PDT Comment hidden (obsolete)

Comment on attachment 373273 [details] Patch Attachment 373273 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12632433 New failing tests: fast/text/mark-matches-overflow-clip-async-scrolling.html

EWS Watchlist

Comment 10 2019-07-01 17:09:58 PDT Comment hidden (obsolete)

Created attachment 373282 [details] Archive of layout-test-results from ews113 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-highsierra Platform: Mac OS X 10.13.6

Tim Horton

Comment 11 2019-07-01 17:11:09 PDT

Created attachment 373283 [details] Patch

EWS Watchlist

Comment 12 2019-07-01 18:24:17 PDT

Comment on attachment 373283 [details] Patch Attachment 373283 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12633597 New failing tests: fast/text/mark-matches-overflow-clip-async-scrolling.html

EWS Watchlist

Comment 13 2019-07-01 18:24:19 PDT

Created attachment 373295 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 14 2019-07-01 18:33:02 PDT

Comment on attachment 373283 [details] Patch Attachment 373283 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12633620 New failing tests: fast/text/mark-matches-overflow-clip-async-scrolling.html

EWS Watchlist

Comment 15 2019-07-01 18:33:04 PDT

Created attachment 373297 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 16 2019-07-01 18:46:09 PDT

Comment on attachment 373283 [details] Patch Attachment 373283 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12633503 New failing tests: fast/text/mark-matches-overflow-clip-async-scrolling.html

EWS Watchlist

Comment 17 2019-07-01 18:46:11 PDT

Created attachment 373298 [details] Archive of layout-test-results from ews113 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-highsierra Platform: Mac OS X 10.13.6

Tim Horton

Comment 18 2019-07-01 18:57:24 PDT

I'm a dummy and uploaded the before result as the expected :|

Tim Horton

Comment 19 2019-07-01 18:58:52 PDT

Created attachment 373299 [details] patch

Simon Fraser (smfr)

Comment 20 2019-07-03 21:12:26 PDT

Did this land?

Tim Horton

Comment 21 2019-07-03 22:41:06 PDT

Don’t think so, was fighting EWS.

Chris Lord

Comment 22 2021-05-21 04:05:33 PDT

absoluteClippedOverflowRect has now been replaced by absoluteClippedOverflowRectForRepaint (which is affected by composited scrolling) and absoluteClippedOverflowRectForSpatialNavigation (which isn't).

Note You need to log in before you can comment on or make changes to this bug.