Bug 202064

Summary: Flaky crash in AudioSourceProviderAVFObjC::~AudioSourceProviderAVFObjC on webaudio/silent-audio-interrupted-in-background.html
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: Web AudioAssignee: WebKit Commit Bot <commit-queue>
Status: NEW    
Severity: Normal CC: ap, cdumez, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, tsavell, webkit-bot-watchers-bugzilla
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=203538
Bug Depends on:    
Bug Blocks: 50856    
Attachments:
Description Flags
Archive of layout-test-results from webkit-cq-01
none
Archive of layout-test-results from webkit-cq-01
none
Patch
none
Patch ap: review+, ap: commit-queue-

WebKit Commit Bot
Reported 2019-09-20 16:58:10 PDT
This is an automatically generated bug from the commit-queue. webaudio/silent-audio-interrupted-in-background.html has been flaky on the commit-queue. webaudio/silent-audio-interrupted-in-background.html was authored by cdumez@apple.com. https://trac.webkit.org/browser/trunk/LayoutTests/webaudio/silent-audio-interrupted-in-background.html The commit-queue just saw webaudio/silent-audio-interrupted-in-background.html flake (DumpRenderTree crashed) while processing attachment 379228 [details] on bug 202040. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.13.6 The bots will update this with information from each new failure. If you believe this bug to be fixed or invalid, feel free to close. The bots will re-open if the flake re-occurs. If you would like to track this test fix with another bug, please close this bug as a duplicate. The bots will follow the duplicate chain when making future comments.
Attachments
Archive of layout-test-results from webkit-cq-01 (3.28 MB, application/zip)
2019-09-20 16:58 PDT, WebKit Commit Bot 		no flags
Details
Archive of layout-test-results from webkit-cq-01 (3.85 MB, application/zip)
2019-11-07 12:31 PST, WebKit Commit Bot 		no flags
Details
Patch (2.34 KB, patch)
2019-12-20 14:30 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (3.74 KB, patch)
2019-12-20 15:00 PST, Jer Noble 		ap: review+
ap: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
WebKit Commit Bot
Comment 1 2019-09-20 16:58:12 PDT
Created attachment 379286 [details] Archive of layout-test-results from webkit-cq-01
Alexey Proskuryakov
Comment 2 2019-09-23 10:34:02 PDT
This rare crash is tracked as rdar://problem/49602546 Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x0000000114206760 WebCore::AudioSourceProviderAVFObjC::~AudioSourceProviderAVFObjC() + 192 (AudioSourceProviderAVFObjC.mm:92) 1 com.apple.WebCore 0x00000001142069fe WebCore::AudioSourceProviderAVFObjC::~AudioSourceProviderAVFObjC() + 14 (ThreadSafeRefCounted.h:37) 2 com.apple.WebCore 0x00000001142c4171 WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC() + 1825 (utility:896) 3 com.apple.WebCore 0x00000001142c496e WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC() + 14 (MediaPlayerPrivate.h:36) 4 com.apple.WebCore 0x0000000115503c9d WebCore::MediaPlayer::~MediaPlayer() + 253 (Timer.h:109) 5 com.apple.WebCore 0x0000000115503cfe WebCore::MediaPlayer::~MediaPlayer() + 14 (MediaPlayer.h:248) 6 com.apple.WebCore 0x00000001150d6ead WebCore::HTMLMediaElement::clearMediaPlayer() + 477 (Node.h:354) 7 com.apple.WebCore 0x00000001150d77e9 WebCore::HTMLMediaElement::stop() + 137 (memory:2567) 8 com.apple.WebCore 0x0000000114f648bd WTF::Detail::CallableWrapper<WebCore::ScriptExecutionContext::stopActiveDOMObjects()::$_6, WebCore::ScriptExecutionContext::ShouldContinue, WebCore::ActiveDOMObject&>::call(WebCore::ActiveDOMObject&) + 13 (Function.h:52) 9 com.apple.WebCore 0x0000000114f5ed35 WebCore::ScriptExecutionContext::forEachActiveDOMObject(WTF::Function<WebCore::ScriptExecutionContext::ShouldContinue (WebCore::ActiveDOMObject&)> const&) const + 485 (ScriptExecutionContext.cpp:271) 10 com.apple.WebCore 0x0000000114f5eef5 WebCore::ScriptExecutionContext::stopActiveDOMObjects() + 69 (memory:2285) 11 com.apple.WebCore 0x0000000114ec7559 WebCore::Document::prepareForDestruction() + 809 (DocumentEventQueue.cpp:134) 12 com.apple.WebCore 0x00000001153b8d11 WebCore::Frame::setView(WTF::RefPtr<WebCore::FrameView, WTF::DumbPtrTraits<WebCore::FrameView> >&&) + 177 (Frame.cpp:234) 13 com.apple.WebKitLegacy 0x0000000112f81340 WebFrameLoaderClient::transitionToCommittedForNewPage() + 448 (utility:896)
WebKit Commit Bot
Comment 3 2019-11-07 12:30:58 PST
The commit-queue just saw webaudio/silent-audio-interrupted-in-background.html flake (DumpRenderTree crashed) while processing attachment 382798 [details] on bug 203836. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.13.6
WebKit Commit Bot
Comment 4 2019-11-07 12:31:00 PST
Created attachment 383067 [details] Archive of layout-test-results from webkit-cq-01
Truitt Savell
Comment 5 2019-12-20 12:41:21 PST
I marked this as a flakey crash in https://trac.webkit.org/changeset/253836/webkit
Jer Noble
Comment 6 2019-12-20 14:30:00 PST
Created attachment 386255 [details] Patch
Alexey Proskuryakov
Comment 7 2019-12-20 14:49:26 PST
Comment on attachment 386255 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386255&action=review > Source/WebCore/ChangeLog:3 > + Flaky crash in AudioSourceProviderAVFObjC::~AudioSourceProviderAVFObjC on webaudio/silent-audio-interrupted-in-background.html Thank you for the fix! Can you update TestExpectations in the same patch?
Jer Noble
Comment 8 2019-12-20 14:58:23 PST
(In reply to Alexey Proskuryakov from comment #7) > Comment on attachment 386255 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=386255&action=review > > > Source/WebCore/ChangeLog:3 > > + Flaky crash in AudioSourceProviderAVFObjC::~AudioSourceProviderAVFObjC on webaudio/silent-audio-interrupted-in-background.html > > Thank you for the fix! Can you update TestExpectations in the same patch? Sure thing.
Jer Noble
Comment 9 2019-12-20 15:00:25 PST
Created attachment 386263 [details] Patch
Alexey Proskuryakov
Comment 10 2019-12-20 17:03:02 PST
Comment on attachment 386263 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386263&action=review The fix looks right to me, TestExpectations need a bit more polish. > LayoutTests/platform/mac-wk2/TestExpectations:-679 > -webkit.org/b/172201 webaudio/silent-audio-interrupted-in-background.html [ Pass Timeout ] This is not the [ Pass Crash ] expectation that Truitt added in https://trac.webkit.org/changeset/253836/webkit
Note You need to log in before you can comment on or make changes to this bug.