Bug 202125

Summary: Update selections after scrolling for iframes and hide selections while iframes and overflow scrolls are scrolling.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, fred.wang, fujii.hironori, jamesr, japhet, luiz, simon.fraser, thorton, tonikitoo, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=138201
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews213 for win-future
none
Patch
none
Patch
none
Patch none

Megan Gardner
Reported 2019-09-23 18:44:21 PDT
Update selection scrolls for iframes and hide selections while iframs and overflow scrolls are scrolling.
Attachments
Patch (5.08 KB, patch)
2019-09-23 18:55 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews213 for win-future (13.50 MB, application/zip)
2019-09-23 21:17 PDT, EWS Watchlist 		no flags
Details
Patch (5.02 KB, patch)
2019-09-24 14:57 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (11.45 KB, patch)
2019-09-24 20:32 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (16.79 KB, patch)
2019-09-25 14:02 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2019-09-23 18:55:21 PDT
Created attachment 379415 [details] Patch
EWS Watchlist
Comment 2 2019-09-23 21:17:03 PDT
Comment on attachment 379415 [details] Patch Attachment 379415 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13062438 New failing tests: storage/indexeddb/modern/new-database-after-user-delete.html
EWS Watchlist
Comment 3 2019-09-23 21:17:06 PDT
Created attachment 379427 [details] Archive of layout-test-results from ews213 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews213 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Megan Gardner
Comment 4 2019-09-24 14:57:53 PDT
Created attachment 379498 [details] Patch
Megan Gardner
Comment 5 2019-09-24 14:59:05 PDT
<rdar://problem/14944104>
Megan Gardner
Comment 6 2019-09-24 20:32:48 PDT
Created attachment 379523 [details] Patch
Simon Fraser (smfr)
Comment 7 2019-09-25 04:39:54 PDT
Comment on attachment 379523 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379523&action=review > Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp:349 > + if (!frameViewPtr->frame().isMainFrame()) { > + if (scrollingLayerPositionAction == ScrollingLayerPositionAction::Set) > + m_page->editorClient().overflowScrollPositionChanged(); > + } If this is called for subframes, then "overflowScrollPositionChanged" is mis-named.
Tim Horton
Comment 8 2019-09-25 09:01:32 PDT
It’s true, though that mistake is made in many places. But maybe we don’t need to make it in WebCore. (Even worse right now WebKit->UIKit calls main frame scrolls to be “overflow”, which is part of what this is fixing).
Megan Gardner
Comment 9 2019-09-25 14:02:21 PDT
Created attachment 379578 [details] Patch
Tim Horton
Comment 10 2019-09-25 15:02:43 PDT
We can fix the names in WebKit in a future patch (maybe we need a word for “I frame or overflow”? I say “sub scrollable region” but I don’t know that we ever say that in the code).
WebKit Commit Bot
Comment 11 2019-09-25 15:54:23 PDT
Comment on attachment 379578 [details] Patch Clearing flags on attachment: 379578 Committed r250365: <https://trac.webkit.org/changeset/250365>
WebKit Commit Bot
Comment 12 2019-09-25 15:54:25 PDT
All reviewed patches have been landed. Closing bug.
Fujii Hironori
Comment 13 2019-09-25 18:45:01 PDT
Committed r250374: <https://trac.webkit.org/changeset/250374>
Note You need to log in before you can comment on or make changes to this bug.