Bug 202919

Summary: [CSS Shadow Parts] ::part rules should be able to override style attribute
Product: WebKit Reporter: Emilio Cobos Álvarez (:emilio) <emilio>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, commit-queue, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jan, koivisto, macpherson, menard, rniwa, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 203029    
Bug Blocks: 149443    
Attachments:
Description Flags
Testcase.
none
patch
none
patch
none
patch
none
patch none

Emilio Cobos Álvarez (:emilio)
Reported 2019-10-14 01:19:04 PDT
Created attachment 380861 [details] Testcase. See the test-case. WebKit trunk behaves the same as Firefox, but I think Chromium is technically correct.
Attachments
Testcase. (617 bytes, text/html)
2019-10-14 01:19 PDT, Emilio Cobos Álvarez (:emilio) 		no flags
Details
patch (13.28 KB, patch)
2019-10-16 08:03 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (17.35 KB, patch)
2019-10-17 04:43 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (18.15 KB, patch)
2019-10-18 02:28 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (18.08 KB, patch)
2019-10-18 02:40 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jan Miksovsky
Comment 1 2019-10-15 16:36:33 PDT
I filed https://github.com/w3c/webcomponents/issues/847 just to make sure everyone's on board with following Chrome's behavior.
Antti Koivisto
Comment 2 2019-10-16 00:16:44 PDT
Inline style is simply appended to the matching declaration list, and not sorted with the rest of the author style, because before this feature it would always win.
Antti Koivisto
Comment 3 2019-10-16 08:03:44 PDT
Created attachment 381069 [details] patch
Antti Koivisto
Comment 4 2019-10-17 04:43:19 PDT
Created attachment 381189 [details] patch
Antti Koivisto
Comment 5 2019-10-18 02:28:37 PDT
Created attachment 381286 [details] patch
Antti Koivisto
Comment 6 2019-10-18 02:40:33 PDT
Created attachment 381289 [details] patch
WebKit Commit Bot
Comment 7 2019-10-18 09:19:31 PDT
The commit-queue encountered the following flaky tests while processing attachment 381289 [details]: fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2019-10-18 09:20:23 PDT
Comment on attachment 381289 [details] patch Clearing flags on attachment: 381289 Committed r251285: <https://trac.webkit.org/changeset/251285>
WebKit Commit Bot
Comment 9 2019-10-18 09:20:25 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2019-10-18 09:21:14 PDT
<rdar://problem/56408673>
Note You need to log in before you can comment on or make changes to this bug.