Bug 205547

Summary: [Media in GPU process] Add remote media player proxy configuration
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, ews-watchlist, glenn, jer.noble, philipj, sergio, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=205630
Bug Depends on:    
Bug Blocks: 205123    
Attachments:
Description Flags
Patch none

Eric Carlson
Reported 2019-12-21 19:58:32 PST
Add remote media player proxy configuration for static player properties.
Attachments
Patch (26.95 KB, patch)
2019-12-21 21:34 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-12-21 19:58:42 PST
<rdar://problem/58139762>
Eric Carlson
Comment 2 2019-12-21 21:34:55 PST
Created attachment 386312 [details] Patch
WebKit Commit Bot
Comment 3 2019-12-22 04:59:41 PST
Comment on attachment 386312 [details] Patch Clearing flags on attachment: 386312 Committed r253871: <https://trac.webkit.org/changeset/253871>
WebKit Commit Bot
Comment 4 2019-12-22 04:59:43 PST
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 5 2019-12-26 17:39:10 PST
Comment on attachment 386312 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386312&action=review > Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerConfiguration.h:93 > + WTFMove(*engineDescription), > + WTFMove(*supportsScanning), > + WTFMove(*supportsPictureInPicture), > + WTFMove(*supportsAcceleratedRendering), > + WTFMove(*canPlayToWirelessPlaybackTarget), The WTFMove for engineDescription is fine. The others seem unnecessary. We don’t need to WTFMove a bool.
Eric Carlson
Comment 6 2019-12-29 09:57:11 PST
(In reply to Darin Adler from comment #5) > Comment on attachment 386312 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=386312&action=review > > > Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerConfiguration.h:93 > > + WTFMove(*engineDescription), > > + WTFMove(*supportsScanning), > > + WTFMove(*supportsPictureInPicture), > > + WTFMove(*supportsAcceleratedRendering), > > + WTFMove(*canPlayToWirelessPlaybackTarget), > > The WTFMove for engineDescription is fine. The others seem unnecessary. We > don’t need to WTFMove a bool. I will fix this in 205630.
Note You need to log in before you can comment on or make changes to this bug.