Bug 205799

Summary: The initial value of color-scheme is 'normal', not 'auto'
Product: WebKit Reporter: Rune Lillesveen <rune.lillesveen>
Component: CSSAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, changseok, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jh718.park, joepeck, koivisto, kondapallykalyan, macpherson, menard, ntim, pdr, rniwa, simon.fraser, thorton, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Mac   
OS: macOS 10.14   
Attachments:
Description Flags
To check layout test result
none
To check layout test result ews-feeder: commit-queue-

Rune Lillesveen
Reported 2020-01-06 06:39:49 PST
The initial value of color-scheme was resolved to be 'normal' instead of 'auto' in [1]. This causes many failures in https://wpt.fyi/results/css/css-color-adjust [1] https://github.com/w3c/csswg-drafts/issues/3849
Attachments
To check layout test result (5.12 KB, patch)
2021-09-23 09:52 PDT, Joonghun Park 		no flags
DetailsFormatted DiffDiff
To check layout test result (59.85 KB, patch)
2021-09-23 11:05 PDT, Joonghun Park 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-01-07 14:39:30 PST
<rdar://problem/58388530>
Joonghun Park
Comment 2 2021-09-23 09:52:00 PDT
Created attachment 439054 [details] To check layout test result
Joonghun Park
Comment 3 2021-09-23 11:05:50 PDT
Created attachment 439070 [details] To check layout test result
Aditya Keerthi
Comment 4 2021-09-23 12:12:07 PDT
Comment on attachment 439070 [details] To check layout test result View in context: https://bugs.webkit.org/attachment.cgi?id=439070&action=review > Source/WebCore/css/parser/CSSPropertyParser.cpp:3967 > // Auto is only allowed as a single value, and was handled earlier. This comment needs to be updated.
Joonghun Park
Comment 5 2021-09-23 15:37:43 PDT
Comment on attachment 439070 [details] To check layout test result View in context: https://bugs.webkit.org/attachment.cgi?id=439070&action=review >> Source/WebCore/css/parser/CSSPropertyParser.cpp:3967 >> // Auto is only allowed as a single value, and was handled earlier. > > This comment needs to be updated. Ok, I will change this in the next patchset.
Timothy Hatcher
Comment 6 2021-09-23 15:51:35 PDT
Mail and Safari, which looks for "auto" in some dark mode detection scripts, will need updated after this change lands. See bug 224810.
Joonghun Park
Comment 7 2021-09-23 17:25:14 PDT
(In reply to Timothy Hatcher from comment #6) > Mail and Safari, which looks for "auto" in some dark mode detection scripts, > will need updated after this change lands. > > See bug 224810. It seems that this bug is duplicated with 224810. Then I will mark this bug as duplicated.
Joonghun Park
Comment 8 2021-09-23 17:26:42 PDT
*** This bug has been marked as a duplicate of bug 224810 ***
Darin Adler
Comment 9 2021-09-28 12:19:25 PDT
(In reply to Timothy Hatcher from comment #6) > Mail and Safari, which looks for "auto" in some dark mode detection scripts, > will need updated after this change lands. Can we instead update them beforehand to work with both "auto" and "normal"?
Tim Nguyen (:ntim)
Comment 10 2022-08-18 21:04:03 PDT
Unduping, I think this is worth doing separately.
Tim Nguyen (:ntim)
Comment 11 2022-08-18 21:59:17 PDT
Pull request: https://github.com/WebKit/WebKit/pull/3471
EWS
Comment 12 2022-08-22 15:09:34 PDT
Committed 253659@main (1ec4bb7857c4): <https://commits.webkit.org/253659@main> Reviewed commits have been landed. Closing PR #3471 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.