Bug 206404

Summary:

Bytecode checkpoints break 32bit tests

Product:

WebKit

Reporter:

Paulo Matos <pmatos>

Component:

JavaScriptCore

Assignee:

Caio Lima <ticaiolima>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, ticaiolima, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Paulo Matos

Reported 2020-01-17 00:44:46 PST

The reland of the bytecode checkpoints (https://bugs.webkit.org/show_bug.cgi?id=206361) break 32bit tests: https://build.webkit.org/builders/JSCOnly%20Linux%20ARMv7%20Thumb2%20Release/builds/10571

Attachments
Patch (1.19 KB, patch) 2020-01-17 04:10 PST, Caio Lima	no flags	Details Formatted Diff Diff
Patch (1.30 KB, patch) 2020-01-17 07:26 PST, Caio Lima	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Paulo Matos

Comment 1 2020-01-17 00:51:18 PST

Failure in debug mode looks like: stress/plus-boolean-or-int.js.mini-mode: ASSERTION FAILED: returnAddress >= instructionsBegin && returnAddress < instructionsEnd stress/plus-boolean-or-int.js.mini-mode: ../../Source/JavaScriptCore/bytecode/CodeBlock.h(394) : unsigned int JSC::CodeBlock::bytecodeOffset(const JSC::Instruction*) stress/plus-boolean-or-int.js.mini-mode: Aborted stress/plus-boolean-or-int.js.mini-mode: ERROR: Unexpected exit code: 134

Caio Lima

Comment 2 2020-01-17 04:10:25 PST

Created attachment 388027 [details] Patch

Caio Lima

Comment 3 2020-01-17 07:26:54 PST

Created attachment 388036 [details] Patch

WebKit Commit Bot

Comment 4 2020-01-17 08:14:27 PST

Comment on attachment 388036 [details] Patch Clearing flags on attachment: 388036 Committed r254748: <https://trac.webkit.org/changeset/254748>

WebKit Commit Bot

Comment 5 2020-01-17 08:14:29 PST

All reviewed patches have been landed. Closing bug.