Bug 208196

Summary: [JSC][MIPS] Adding support to Checkpoints
Product: WebKit Reporter: Caio Lima <ticaiolima>
Component: JavaScriptCoreAssignee: Caio Lima <ticaiolima>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, jsc32, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Caio Lima
Reported 2020-02-25 07:40:46 PST
...
Attachments
Patch (6.22 KB, patch)
2020-02-25 08:23 PST, Caio Lima 		no flags
DetailsFormatted DiffDiff
Patch (6.42 KB, patch)
2020-02-26 05:09 PST, Caio Lima 		no flags
DetailsFormatted DiffDiff
Patch (6.41 KB, patch)
2020-02-26 05:16 PST, Caio Lima 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Caio Lima
Comment 1 2020-02-25 08:23:11 PST
Created attachment 391653 [details] Patch
Yusuke Suzuki
Comment 2 2020-02-25 13:07:24 PST
Comment on attachment 391653 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391653&action=review r=me > Source/JavaScriptCore/offlineasm/mips.rb:688 > + if node.name =~ /^.*_return_location(?:_(?:wide16|wide32))?$/ or node.name.start_with?("_checkpoint_osr_exit_from_inlined_call_trampoline") This sounds like, we should rename _checkpoint_osr_exit_from_inlined_call_trampoline to _checkpoint_osr_exit_from_inlined_call_trampoline_return_location, because it is return-location. Can you file a FIXME here?
Caio Lima
Comment 3 2020-02-26 05:09:10 PST
Created attachment 391738 [details] Patch
Caio Lima
Comment 4 2020-02-26 05:16:12 PST
Created attachment 391739 [details] Patch
Caio Lima
Comment 5 2020-02-26 05:20:03 PST
(In reply to Yusuke Suzuki from comment #2) > Comment on attachment 391653 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=391653&action=review > > r=me Thank you very much for the review! > > Source/JavaScriptCore/offlineasm/mips.rb:688 > > + if node.name =~ /^.*_return_location(?:_(?:wide16|wide32))?$/ or node.name.start_with?("_checkpoint_osr_exit_from_inlined_call_trampoline") > > This sounds like, we should rename > _checkpoint_osr_exit_from_inlined_call_trampoline to > _checkpoint_osr_exit_from_inlined_call_trampoline_return_location, because > it is return-location. > Can you file a FIXME here? Done. I created https://bugs.webkit.org/show_bug.cgi?id=208236 and I'm going to upload a patch soon.
WebKit Commit Bot
Comment 6 2020-02-26 06:06:36 PST
Comment on attachment 391739 [details] Patch Clearing flags on attachment: 391739 Committed r257466: <https://trac.webkit.org/changeset/257466>
WebKit Commit Bot
Comment 7 2020-02-26 06:06:38 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2020-02-26 06:07:19 PST
<rdar://problem/59803601>
Note You need to log in before you can comment on or make changes to this bug.