Bug 208247

Summary:

[LFC][BFC][MarginCollapsing] Decouple regular and pre-computed margin collapsing logic

Product:

WebKit

Reporter:

alan <zalan>

Component:

Layout and Rendering

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, fujii.hironori, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Build fix	none
Non-unified build fix	commit-queue: commit-queue-
Non-unified build fix	none
Non-unified build fix#2	none
Non-unified build fix#2	none

alan

Reported 2020-02-26 09:44:22 PST

pre-computed is so peculiar it deserves a dedicated file.

Attachments
Patch (15.53 KB, patch) 2020-02-26 09:50 PST, alan	no flags	Details Formatted Diff Diff
Build fix (3.91 KB, patch) 2020-02-27 07:27 PST, alan	no flags	Details Formatted Diff Diff
Non-unified build fix (3.91 KB, patch) 2020-02-27 07:34 PST, alan	commit-queue: commit-queue-	Details Formatted Diff Diff
Non-unified build fix (3.93 KB, patch) 2020-02-27 07:46 PST, alan	no flags	Details Formatted Diff Diff
Non-unified build fix#2 (2.31 KB, patch) 2020-03-01 18:12 PST, alan	no flags	Details Formatted Diff Diff
Non-unified build fix#2 (2.31 KB, patch) 2020-03-01 18:22 PST, alan	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2020-02-26 09:44:40 PST

<rdar://problem/59808951>

alan

Comment 2 2020-02-26 09:50:47 PST

Created attachment 391752 [details] Patch

WebKit Commit Bot

Comment 3 2020-02-26 13:31:04 PST

Comment on attachment 391752 [details] Patch Clearing flags on attachment: 391752 Committed r257507: <https://trac.webkit.org/changeset/257507>

WebKit Commit Bot

Comment 4 2020-02-26 13:31:05 PST

All reviewed patches have been landed. Closing bug.

Fujii Hironori

Comment 5 2020-02-26 23:22:47 PST

Comment on attachment 391752 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391752&action=review > Source/WebCore/layout/blockformatting/PrecomputedBlockMarginCollapse.cpp:66 > + auto collapsedMarginBefore = computedPositiveAndNegativeMargin(firstChildCollapsedMarginBefore(), previouSiblingCollapsedMarginAfter()); computedPositiveAndNegativeMargin is defined in BlockFormattingContext.cpp. It can't be used in --no-unified-builds. I don't know how to fix. Please fix it.

alan

Comment 6 2020-02-27 07:27:56 PST

Created attachment 391862 [details] Build fix

alan

Comment 7 2020-02-27 07:33:41 PST

fix non-unified builds

alan

Comment 8 2020-02-27 07:34:50 PST

Created attachment 391865 [details] Non-unified build fix

WebKit Commit Bot

Comment 9 2020-02-27 07:43:15 PST

Comment on attachment 391865 [details] Non-unified build fix Rejecting attachment 391865 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 391865, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: https://webkit-queues.webkit.org/results/13329925

alan

Comment 10 2020-02-27 07:46:15 PST

Created attachment 391867 [details] Non-unified build fix

WebKit Commit Bot

Comment 11 2020-02-27 08:52:12 PST

The commit-queue encountered the following flaky tests while processing attachment 391867 [details]: imported/w3c/web-platform-tests/xhr/open-after-stop.window.html bug 208320 (author: cdumez@apple.com) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 12 2020-02-27 08:52:52 PST

Comment on attachment 391867 [details] Non-unified build fix Clearing flags on attachment: 391867 Committed r257568: <https://trac.webkit.org/changeset/257568>

WebKit Commit Bot

Comment 13 2020-02-27 08:52:54 PST

All reviewed patches have been landed. Closing bug.

alan

Comment 14 2020-03-01 18:12:33 PST

Created attachment 392112 [details] Non-unified build fix#2

alan

Comment 15 2020-03-01 18:21:59 PST

fix non-unified builds

alan

Comment 16 2020-03-01 18:22:46 PST

Created attachment 392113 [details] Non-unified build fix#2

WebKit Commit Bot

Comment 17 2020-03-01 20:29:14 PST

Comment on attachment 392113 [details] Non-unified build fix#2 Clearing flags on attachment: 392113 Committed r257701: <https://trac.webkit.org/changeset/257701>

WebKit Commit Bot

Comment 18 2020-03-01 20:29:16 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.