Bug 208703

Summary: [WebAuthn] Customize a bit more on the macOS LocalAuthentication prompt
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebKit Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, darin, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 181943    
Attachments:
Description Flags
Patch
none
Patch
darin: review+
Patch for landing
jiewen_tan: commit-queue-
Patch for landing
none
Part 2
bfulgham: review+
Part 2
none
Part 2
none
Part 2
bfulgham: review+
Patch for landing none

Jiewen Tan
Reported 2020-03-06 02:36:00 PST
Customize a bit more on the macOS LocalAuthentication prompt.
Attachments
Patch (11.65 KB, patch)
2020-03-06 02:43 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (12.02 KB, patch)
2020-03-06 14:07 PST, Jiewen Tan 		darin: review+
DetailsFormatted DiffDiff
Patch for landing (18.28 KB, patch)
2020-03-13 15:14 PDT, Jiewen Tan 		jiewen_tan: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (11.97 KB, patch)
2020-03-13 15:27 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Part 2 (11.30 KB, patch)
2020-03-16 14:54 PDT, Jiewen Tan 		bfulgham: review+
DetailsFormatted DiffDiff
Part 2 (18.31 KB, patch)
2020-03-20 00:22 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Part 2 (20.88 KB, patch)
2020-03-22 20:56 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Part 2 (20.43 KB, patch)
2020-03-22 21:01 PDT, Jiewen Tan 		bfulgham: review+
DetailsFormatted DiffDiff
Patch for landing (20.22 KB, patch)
2020-03-24 16:11 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-03-06 02:36:30 PST
<rdar://problem/60136974>
Jiewen Tan
Comment 2 2020-03-06 02:43:14 PST
Created attachment 392696 [details] Patch
Jiewen Tan
Comment 3 2020-03-06 14:07:08 PST
Created attachment 392771 [details] Patch
Darin Adler
Comment 4 2020-03-08 23:14:36 PDT
Comment on attachment 392771 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392771&action=review > Source/WebCore/en.lproj/Localizable.strings:887 > +"Touch ID to allow signning into â%@â with Touch ID." = "Touch ID to allow signning into â%@â with Touch ID."; Spelling error here in the word "signing" > Source/WebCore/platform/LocalizedStrings.cpp:1218 > + return formatLocalizedString(WEB_UI_CFSTRING("Touch ID to allow signning into â%@â with Touch ID.", "Allow using Touch ID to sign into the specified website on this device"), rpId.createCFString().get()); Ditto. > Source/WebCore/platform/LocalizedStrings.h:344 > + WEBCORE_EXPORT String makeCredentialTouchIDPromptTitle(const String& rpId); Do we really have to call this "rpId"? Are there words we could use instead? > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:52 > +#elif PLATFORM(MAC) I think we should just use #else here.
Jiewen Tan
Comment 5 2020-03-13 14:51:08 PDT
Comment on attachment 392771 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392771&action=review Thanks Darin for the r+! >> Source/WebCore/en.lproj/Localizable.strings:887 >> +"Touch ID to allow signning into â%@â with Touch ID." = "Touch ID to allow signning into â%@â with Touch ID."; > > Spelling error here in the word "signing" Fixed. >> Source/WebCore/platform/LocalizedStrings.cpp:1218 >> + return formatLocalizedString(WEB_UI_CFSTRING("Touch ID to allow signning into â%@â with Touch ID.", "Allow using Touch ID to sign into the specified website on this device"), rpId.createCFString().get()); > > Ditto. Fixed. >> Source/WebCore/platform/LocalizedStrings.h:344 >> + WEBCORE_EXPORT String makeCredentialTouchIDPromptTitle(const String& rpId); > > Do we really have to call this "rpId"? Are there words we could use instead? We could call it domain. >> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:52 >> +#elif PLATFORM(MAC) > > I think we should just use #else here. Fixed.
Jiewen Tan
Comment 6 2020-03-13 15:14:07 PDT
Created attachment 393535 [details] Patch for landing
Jiewen Tan
Comment 7 2020-03-13 15:26:43 PDT
Comment on attachment 393535 [details] Patch for landing Always be tricked by the fact that webkit-patch upload will bundle any local changes into one patch.
Jiewen Tan
Comment 8 2020-03-13 15:27:57 PDT
Created attachment 393537 [details] Patch for landing
WebKit Commit Bot
Comment 9 2020-03-13 16:15:36 PDT
Comment on attachment 393537 [details] Patch for landing Clearing flags on attachment: 393537 Committed r258442: <https://trac.webkit.org/changeset/258442>
Jiewen Tan
Comment 10 2020-03-16 14:54:03 PDT
Created attachment 393687 [details] Part 2
Brent Fulgham
Comment 11 2020-03-19 17:53:28 PDT
Comment on attachment 393687 [details] Part 2 r=me
Jiewen Tan
Comment 12 2020-03-20 00:22:20 PDT
Created attachment 394070 [details] Part 2
Jiewen Tan
Comment 13 2020-03-20 00:23:30 PDT
(In reply to Brent Fulgham from comment #11) > Comment on attachment 393687 [details] > Part 2 > > r=me Thanks for the review. I just upload a newer version which addresses comments from our Tuesday meeting.
Darin Adler
Comment 14 2020-03-22 18:33:31 PDT
Comment on attachment 394070 [details] Part 2 View in context: https://bugs.webkit.org/attachment.cgi?id=394070&action=review > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:55 > + NSBundle *mainBundle = [NSBundle mainBundle]; > + bundleName = appBundle.infoDictionary[(id)_kCFBundleDisplayNameKey]; > + if (!bundleName) > + bundleName = appBundle.infoDictionary[(id)kCFBundleNameKey]; > + if (!bundleName) > + bundleName = [mainBundle bundleIdentifier]; This code is not compiling on iOS bots
Jiewen Tan
Comment 15 2020-03-22 19:22:26 PDT
(In reply to Darin Adler from comment #14) > Comment on attachment 394070 [details] > Part 2 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=394070&action=review > > > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:55 > > + NSBundle *mainBundle = [NSBundle mainBundle]; > > + bundleName = appBundle.infoDictionary[(id)_kCFBundleDisplayNameKey]; > > + if (!bundleName) > > + bundleName = appBundle.infoDictionary[(id)kCFBundleNameKey]; > > + if (!bundleName) > > + bundleName = [mainBundle bundleIdentifier]; > > This code is not compiling on iOS bots I fixed that locally but was struggling to get an iOS device to run. Will upload a new patch soon once I'm done testing on my iOS device.
Jiewen Tan
Comment 16 2020-03-22 20:56:51 PDT
Created attachment 394239 [details] Part 2
Jiewen Tan
Comment 17 2020-03-22 21:01:53 PDT
Created attachment 394240 [details] Part 2
Brent Fulgham
Comment 18 2020-03-24 16:01:05 PDT
Comment on attachment 394240 [details] Part 2 View in context: https://bugs.webkit.org/attachment.cgi?id=394240&action=review R=me > Source/WebKit/ChangeLog:12 > + And tunes a bit on the makeCredential string. It also polishes the text used for makeCredential. > Source/WebKit/ChangeLog:14 > + Besides that, it also enhances the iOS titles as well. Besides that, it also enhances the iOS title strings.
Jiewen Tan
Comment 19 2020-03-24 16:09:01 PDT
Comment on attachment 394240 [details] Part 2 View in context: https://bugs.webkit.org/attachment.cgi?id=394240&action=review Thanks Brent for the r+. >> Source/WebKit/ChangeLog:12 >> + And tunes a bit on the makeCredential string. > > It also polishes the text used for makeCredential. Fixed. >> Source/WebKit/ChangeLog:14 >> + Besides that, it also enhances the iOS titles as well. > > Besides that, it also enhances the iOS title strings. Fixed.
Jiewen Tan
Comment 20 2020-03-24 16:11:39 PDT
Created attachment 394434 [details] Patch for landing
EWS
Comment 21 2020-03-24 17:03:26 PDT
Committed r258961: <https://trac.webkit.org/changeset/258961> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394434 [details].
Note You need to log in before you can comment on or make changes to this bug.