Bug 212639

Summary:

Resync web-platform-tests/2dcontext from upstream

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Tools / Tests

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, clopez, dino, ggaren, jacob_uphoff, sabouhallawa, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=212613
https://bugs.webkit.org/show_bug.cgi?id=212770

Bug Depends on:

Bug Blocks:

213927

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	youennf: review+, ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	none

Chris Dumez

Reported 2020-06-02 09:14:51 PDT

Resync web-platform-tests/2dcontext from upstream.

Attachments
Patch (7.62 MB, patch) 2020-06-02 11:03 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (7.62 MB, patch) 2020-06-02 11:24 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (7.62 MB, patch) 2020-06-02 13:15 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (7.78 MB, patch) 2020-06-02 17:01 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (7.79 MB, patch) 2020-06-02 22:26 PDT, Chris Dumez	youennf: review+ ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (7.79 MB, patch) 2020-06-03 10:29 PDT, Chris Dumez	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (7.79 MB, patch) 2020-06-03 13:22 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2020-06-02 09:22:41 PDT

Those tests got moved upstream: 2dcontext -> html/canvas/element

Chris Dumez

Comment 2 2020-06-02 11:03:10 PDT

Created attachment 400840 [details] Patch

Chris Dumez

Comment 3 2020-06-02 11:24:54 PDT

Created attachment 400847 [details] Patch

Chris Dumez

Comment 4 2020-06-02 13:15:58 PDT

Created attachment 400850 [details] Patch

Chris Dumez

Comment 5 2020-06-02 17:01:11 PDT

Created attachment 400868 [details] Patch

Chris Dumez

Comment 6 2020-06-02 22:26:50 PDT

Created attachment 400898 [details] Patch

youenn fablet

Comment 7 2020-06-03 00:15:25 PDT

As of LayoutTests/canvas/philip/tests/2d.drawImage.incomplete.emptysrc.html and siblings, they are probably obsoleted by WPT tests. If so, it might be good to remove them. Said, wdyt?

EWS

Comment 8 2020-06-03 10:21:57 PDT

Tools/Scripts/svn-apply failed to apply attachment 400898 [details] to trunk. Please resolve the conflicts and upload a new patch.

Chris Dumez

Comment 9 2020-06-03 10:29:53 PDT

Created attachment 400940 [details] Patch

EWS

Comment 10 2020-06-03 12:49:29 PDT

commit-queue failed to commit attachment 400940 [details] to WebKit repository.

Chris Dumez

Comment 11 2020-06-03 13:22:42 PDT

Created attachment 400963 [details] Patch

EWS

Comment 12 2020-06-03 16:01:31 PDT

commit-queue failed to commit attachment 400963 [details] to WebKit repository.

Chris Dumez

Comment 13 2020-06-03 18:05:46 PDT

Committed r262527: <https://trac.webkit.org/changeset/262527>

Radar WebKit Bug Importer

Comment 14 2020-06-03 18:06:36 PDT

<rdar://problem/63954201>

Carlos Alberto Lopez Perez

Comment 15 2020-06-04 04:37:03 PDT

(In reply to Chris Dumez from comment #13) > Committed r262527: <https://trac.webkit.org/changeset/262527> I was working on a similar patch on bug 212613 when i noticed this landing. I don't know how you did this import or what went wrong, but I see it is missing the import of all the new canvas tests. Upstream WPT moved "2dcontext" -> "html/canvas/element" but on r262527 I see no folder LayoutTests/imported/w3c/web-platform-tests/html/canvas Where are the new tests? Also some other tests had resources to that folder that now not longer exist. See all the new failures: https://build.webkit.org/builders/Apple%20Mojave%20Release%20WK2%20%28Tests%29/builds/13538/steps/layout-test/logs/stdio What surprises me is how the EWS was green.. maybe the patch landed was different than the one tested by the EWS?

Chris Dumez

Comment 16 2020-06-04 07:44:21 PDT

(In reply to Carlos Alberto Lopez Perez from comment #15) > (In reply to Chris Dumez from comment #13) > > Committed r262527: <https://trac.webkit.org/changeset/262527> > > I was working on a similar patch on bug 212613 when i noticed this landing. > > I don't know how you did this import or what went wrong, but I see it is > missing the import of all the new canvas tests. > > Upstream WPT moved "2dcontext" -> "html/canvas/element" but on r262527 I see > no folder LayoutTests/imported/w3c/web-platform-tests/html/canvas > > Where are the new tests? > > > Also some other tests had resources to that folder that now not longer exist. > > See all the new failures: > https://build.webkit.org/builders/ > Apple%20Mojave%20Release%20WK2%20%28Tests%29/builds/13538/steps/layout-test/ > logs/stdio > > > What surprises me is how the EWS was green.. maybe the patch landed was > different than the one tested by the EWS? The commit queue refused to commit the patch, likely because it was too big. I had to land manually. It is likely I messed up my local commit and missed new files based on what you are saying. I will look into fixing this this morning.

Chris Dumez

Comment 17 2020-06-04 08:07:23 PDT

Committed r262539: <https://trac.webkit.org/changeset/262539>

Note You need to log in before you can comment on or make changes to this bug.