Bug 212870

Summary: [IPC] Adopt enum class for DragOperation
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebKit2Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, darin, esprehn+autocc, ews-watchlist, kangil.han, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=212885
https://bugs.webkit.org/show_bug.cgi?id=213093
Bug Depends on: 212605    
Bug Blocks: 211988    
Attachments:
Description Flags
Patch v1
none
Patch v2 none

David Kilzer (:ddkilzer)
Reported 2020-06-06 09:25:15 PDT
Adopt enum class for DragOperation.
Attachments
Patch v1 (37.14 KB, patch)
2020-06-06 09:43 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Patch v2 (37.92 KB, patch)
2020-06-06 11:30 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-06-06 09:25:32 PDT
<rdar://problem/64069940>
David Kilzer (:ddkilzer)
Comment 2 2020-06-06 09:43:29 PDT
Created attachment 401264 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 3 2020-06-06 11:30:35 PDT
Created attachment 401270 [details] Patch v2
David Kilzer (:ddkilzer)
Comment 4 2020-06-06 11:31:00 PDT
(In reply to David Kilzer (:ddkilzer) from comment #3) > Created attachment 401270 [details] > Patch v2 Removed FIXME in Source/WebKit/Scripts/webkit/messages.py.
David Kilzer (:ddkilzer)
Comment 5 2020-06-08 09:34:23 PDT
Comment on attachment 401270 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=401270&action=review Ready for review. I called out non-mechanical changes via comments. > Source/WebCore/ChangeLog:19 > + * page/DragActions.h: > + (WebCore::DragOperation): > + - Convert to enum class. This is not a mechanical change. > Source/WebKit/ChangeLog:10 > + * Scripts/webkit/messages.py: > + - Remove FIXME now that it's not needed. This is not a mechanical change. > Tools/ChangeLog:10 > + * Scripts/do-webcore-rename: > + - Do DragOperation renames. Not a mechanical change. (Do we normally update the script like this?)
Darin Adler
Comment 6 2020-06-08 11:20:22 PDT
Comment on attachment 401270 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=401270&action=review >> Tools/ChangeLog:10 >> + - Do DragOperation renames. > > Not a mechanical change. (Do we normally update the script like this?) We do; it’s fine.
EWS
Comment 7 2020-06-08 13:07:05 PDT
Committed r262735: <https://trac.webkit.org/changeset/262735> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401270 [details].
Note You need to log in before you can comment on or make changes to this bug.