Bug 214527

Summary: [LFC][IFC] Move inline run alignment logic to a dedicated class
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 215087, 215752    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

alan
Reported 2020-07-18 20:45:11 PDT
ssia
Attachments
Patch (41.79 KB, patch)
2020-07-18 20:50 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (40.71 KB, patch)
2020-07-18 21:12 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (36.85 KB, patch)
2020-07-31 03:51 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (37.21 KB, patch)
2020-08-25 20:35 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (37.12 KB, patch)
2020-08-26 06:25 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (36.55 KB, patch)
2020-08-26 07:52 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2020-07-18 20:50:29 PDT
Created attachment 404652 [details] Patch
alan
Comment 2 2020-07-18 20:59:12 PDT
Comment on attachment 404652 [details] Patch oops, "vertical-align: middle" logic got in here.
alan
Comment 3 2020-07-18 21:12:12 PDT
Created attachment 404653 [details] Patch
Radar WebKit Bug Importer
Comment 4 2020-07-25 20:46:17 PDT
<rdar://problem/66115796>
alan
Comment 5 2020-07-31 03:51:27 PDT
Created attachment 405680 [details] Patch
alan
Comment 6 2020-08-25 20:35:04 PDT
Created attachment 407269 [details] Patch
alan
Comment 7 2020-08-26 06:25:10 PDT
Created attachment 407293 [details] Patch
alan
Comment 8 2020-08-26 07:52:16 PDT
Created attachment 407297 [details] Patch
Antti Koivisto
Comment 9 2020-08-26 09:25:47 PDT
Comment on attachment 407297 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407297&action=review > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:67 > +class LineContentAligner { Might it deserve a file of its own?
alan
Comment 10 2020-08-26 09:27:42 PDT
(In reply to Antti Koivisto from comment #9) > Comment on attachment 407297 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=407297&action=review > > > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:67 > > +class LineContentAligner { > > Might it deserve a file of its own? It's coming!
EWS
Comment 11 2020-08-26 09:46:08 PDT
Committed r266169: <https://trac.webkit.org/changeset/266169> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407297 [details].
Note You need to log in before you can comment on or make changes to this bug.