Bug 215585

Summary: Develop a mechanism to unsubscribe from ews emails
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, dewei_zhu, jbedard, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 215220    
Attachments:
Description Flags
Patch
none
Patch jbedard: review+

Aakash Jain
Reported 2020-08-17 14:40:55 PDT
Develop a mechanism to unsubscribe from ews emails for patch authors. This is for engineers who prefer not to receive email notifications from ews for the build/test failures on their patches.
Attachments
Patch (7.46 KB, patch)
2020-08-17 14:46 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (7.50 KB, patch)
2020-08-18 08:33 PDT, Aakash Jain 		jbedard: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-08-17 14:46:31 PDT
Created attachment 406745 [details] Patch
Jonathan Bedard
Comment 2 2020-08-17 15:09:54 PDT
Comment on attachment 406745 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406745&action=review > Tools/BuildSlaveSupport/ews-build/emails.json:4 > + "EMAIL_IDS_TO_UNSUBSCRIBE": [] I'm ok with this, but have we thought about other potential possibilities? Seems like this approach is a bit onerous if the unsubscribe rate is very high.
Aakash Jain
Comment 3 2020-08-17 15:25:45 PDT
(In reply to Jonathan Bedard from comment #2) > I'm ok with this, but have we thought about other potential possibilities? Seems like this approach is a bit onerous if the unsubscribe rate is very high. One other approach was to store this information somewhere in Bugzilla, but we might not want this solution to be tightly couple with Bugzilla. In this approach, one consideration was to make sure that we don't need a Buildbot restart to add any email to unsubscribe list to be effective, which this approach fulfills. Another idea I considered was to fetch emails.json from trac (so that unsubscribe would have been effective immediately, without even updating the local checkout on the server), but that would have been little slower, and any breakage in email.json (by someone's manual commmit) would also cause issue immediately. I'm open to other ideas. Also, most likely the unsubscribe rate will settle down few days after starting these emails. Majority of people would be able to decide whether they want to continue receiving the emails or not in a few days.
Jonathan Bedard
Comment 4 2020-08-17 16:40:18 PDT
Comment on attachment 406745 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406745&action=review > Tools/BuildSlaveSupport/ews-build/emails.json:2 > + "ADMIN_EMAILS": ["aakash_jain@apple.com", "webkit-ews-bot-watchers@group.apple.com"], What do we intend on using this for? > Tools/BuildSlaveSupport/ews-build/send_email.py:40 > + except: Bare except is what's breaking the style rules. Maybe just catch BaseException?
Aakash Jain
Comment 5 2020-08-18 08:33:37 PDT
Created attachment 406786 [details] Patch
Aakash Jain
Comment 6 2020-08-18 08:35:11 PDT
(In reply to Jonathan Bedard from comment #4) > > Tools/BuildSlaveSupport/ews-build/emails.json:2 > > + "ADMIN_EMAILS": ["aakash_jain@apple.com", "webkit-ews-bot-watchers@group.apple.com"], > > What do we intend on using this for? This would be used in subsequent patches to enable email notifications for admin for infrastructure issues (like kill-old-processes failure). > > > Tools/BuildSlaveSupport/ews-build/send_email.py:40 > > + except: > > Bare except is what's breaking the style rules. Maybe just catch BaseException? Fixed in updated patch.
Aakash Jain
Comment 7 2020-08-18 09:04:07 PDT
Committed r265817: <https://trac.webkit.org/changeset/265817>
Radar WebKit Bug Importer
Comment 8 2020-08-18 09:05:18 PDT
<rdar://problem/67330693>
Note You need to log in before you can comment on or make changes to this bug.