Bug 216050

Summary: Make sure BiquadFilterNode tail is getting processed
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 212611    
Attachments:
Description Flags
Patch darin: review+

Chris Dumez
Reported 2020-09-01 14:00:53 PDT
Make sure BiquadFilterNode tail is getting processed.
Attachments
Patch (35.37 KB, patch)
2020-09-01 14:05 PDT, Chris Dumez 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-09-01 14:05:27 PDT
Created attachment 407710 [details] Patch
Darin Adler
Comment 2 2020-09-01 14:55:45 PDT
Comment on attachment 407710 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407710&action=review > Source/WebCore/Modules/webaudio/PannerNode.cpp:547 > + return m_panner ? m_panner->requiresTailProcessing() : true; I would write this as: return !m_panner || m_panner->requiresTailProcessing(); For me that seems more readable. Maybe other people find the ? : form more readable? > Source/WebCore/Modules/webaudio/WebKitAudioPannerNode.cpp:355 > + return m_panner ? m_panner->requiresTailProcessing() : true; Ditto.
Chris Dumez
Comment 3 2020-09-01 16:11:59 PDT
Committed r266417: <https://trac.webkit.org/changeset/266417>
Radar WebKit Bug Importer
Comment 4 2020-09-01 16:12:21 PDT
<rdar://problem/68173068>
Note You need to log in before you can comment on or make changes to this bug.