Bug 216576

Summary: Merge PeriodicWave improvements from Blink
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 216569    
Bug Blocks: 212611    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2020-09-15 12:32:09 PDT
Merge PeriodicWave improvements from Blink.
Attachments
Patch (195.87 KB, patch)
2020-09-15 12:57 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (142.61 KB, patch)
2020-09-15 13:03 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (142.69 KB, patch)
2020-09-16 09:05 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (142.70 KB, patch)
2020-09-16 09:50 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-09-15 12:57:36 PDT
Created attachment 408847 [details] Patch
Chris Dumez
Comment 2 2020-09-15 13:03:21 PDT
Created attachment 408849 [details] Patch
Chris Dumez
Comment 3 2020-09-16 09:05:57 PDT
Created attachment 408926 [details] Patch
Darin Adler
Comment 4 2020-09-16 09:47:56 PDT
Comment on attachment 408926 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408926&action=review > Source/WebCore/Modules/webaudio/PeriodicWave.cpp:47 > +// The number of bands per octave. Each octave will have this many entries in the wave tables. > +const unsigned NumberOfOctaveBands = 3; > + > +// The max length of a periodic wave. This must be a power of two greater than > +// or equal to 2048 and must be supported by the FFT routines. > +const unsigned MaxPeriodicWaveSize = 16384; > + > +const float CentsPerRange = 1200 / NumberOfOctaveBands; constexpr unless we want to leave this alone so it’s easier to merge from Chromium
Chris Dumez
Comment 5 2020-09-16 09:50:05 PDT
Created attachment 408929 [details] Patch
EWS
Comment 6 2020-09-16 10:40:19 PDT
Committed r267153: <https://trac.webkit.org/changeset/267153> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408929 [details].
Radar WebKit Bug Importer
Comment 7 2020-09-16 10:41:19 PDT
<rdar://problem/68998577>
Note You need to log in before you can comment on or make changes to this bug.