Bug 217995

Summary: Share more code between WorkerGlobalScope and WorkletGlobalScope
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sam, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 217980    
Bug Blocks: 217724, 217058, 218051    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2020-10-20 15:41:05 PDT
Share more code between WorkerGlobalScope and WorkletGlobalScope.
Attachments
Patch (37.19 KB, patch)
2020-10-20 17:11 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-10-20 17:11:12 PDT
Created attachment 411941 [details] Patch
Chris Dumez
Comment 2 2020-10-21 13:56:49 PDT
Ping review?
Darin Adler
Comment 3 2020-10-21 14:01:15 PDT
Comment on attachment 411941 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411941&action=review > Source/WebCore/workers/WorkerOrWorkletGlobalScope.h:57 > + virtual void prepareForDestruction(); protected?
Chris Dumez
Comment 4 2020-10-21 14:05:01 PDT
Comment on attachment 411941 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411941&action=review > Source/WebCore/Modules/webaudio/AudioWorkletThread.cpp:90 > + workletGlobalScope.prepareForDestruction(); See here. >> Source/WebCore/workers/WorkerOrWorkletGlobalScope.h:57 >> + virtual void prepareForDestruction(); > > protected? No, I don't think we can because it is called from WorkerThread / AudioWorkletThread.
EWS
Comment 5 2020-10-21 14:15:54 PDT
Committed r268822: <https://trac.webkit.org/changeset/268822> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411941 [details].
Radar WebKit Bug Importer
Comment 6 2020-10-21 14:16:38 PDT
<rdar://problem/70544800>
Note You need to log in before you can comment on or make changes to this bug.