Bug 218123

Summary: Rename slave to worker in webkitpy
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ews-watchlist, glenn, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=224988
Bug Depends on:    
Bug Blocks: 213092    
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2020-10-23 07:29:12 PDT
Rename slave to worker in webkitpy. This is to use more inclusive naming.
Attachments
Patch (14.71 KB, patch)
2020-10-23 07:58 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-10-23 07:58:57 PDT
Created attachment 412177 [details] Patch
Jonathan Bedard
Comment 2 2020-10-23 09:08:16 PDT
Comment on attachment 412177 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412177&action=review > Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:578 > + build_worker = self._options.build_slave We will need to expose a "build_worker" option, change all our buildbot invocations, and then remove the "build_slave" option to totally get rid of this. (not particularly difficult, just going to take a few patches and a few buildbot restarts)
Aakash Jain
Comment 3 2020-10-23 09:10:38 PDT
Yeah.
EWS
Comment 4 2020-10-23 09:13:33 PDT
Committed r268925: <https://trac.webkit.org/changeset/268925> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412177 [details].
Radar WebKit Bug Importer
Comment 5 2020-10-23 09:14:22 PDT
<rdar://problem/70621688>
Note You need to log in before you can comment on or make changes to this bug.