Bug 221688

Summary: [GPUP] Two tests related to media element state are flaky when media in GPU Process is enabled
Product: WebKit Reporter: Peng Liu <peng.liu6>
Component: MediaAssignee: Peng Liu <peng.liu6>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=123010
Bug Depends on:    
Bug Blocks: 221830    
Attachments:
Description Flags
Patch none

Peng Liu
Reported 2021-02-10 10:18:21 PST
media/W3C/video/networkState/networkState_during_loadstart.html media/W3C/video/readyState/readyState_during_loadedmetadata.html
Attachments
Patch (6.69 KB, patch)
2021-03-02 17:41 PST, Peng Liu 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-02-17 10:19:14 PST
<rdar://problem/74439045>
Peng Liu
Comment 2 2021-03-02 14:54:09 PST
Test media/W3C/video/readyState/readyState_during_loadedmetadata.html is passing consistently on bots now. Test media/W3C/video/networkState/networkState_during_loadstart.html still fails. But in order to reproduce the failure locally, I have to run more than 2 iterations. Like below: run-webkit-tests --no-build media/W3C/video/networkState/networkState_during_loadstart.html --no-retry-failures --iterations=3
Peng Liu
Comment 3 2021-03-02 15:02:27 PST
Looks like when we run MediaPlayerPrivateAVFoundationObjC in the GPU process, MediaPlayerPrivateAVFoundation::m_networkState changes from MediaPlayer::NetworkState::Loading to MediaPlayer::NetworkState::Loaded quickly, and HTMLMediaElement is notified (HTMLMediaElement::setNetworkState() is called) before the "loadstart" event handler haves the chance to execute. HTMLMediaElement::setNetworkState() will set m_networkState to NETWORK_IDLE in the process, but the test expects expects m_networkState to be NETWORK_LOADING in the "loadstart" event handler.
Peng Liu
Comment 4 2021-03-02 15:07:14 PST
I don't think the flaky failure will impact the functionality.
Peng Liu
Comment 5 2021-03-02 17:41:58 PST
Created attachment 422028 [details] Patch
EWS
Comment 6 2021-03-03 15:54:55 PST
Committed r273853: <https://commits.webkit.org/r273853> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422028 [details].
Note You need to log in before you can comment on or make changes to this bug.