Bug 223254

Summary:

Import css/css-contain test from WPT

Product:

WebKit

Reporter:

cathiechen <cathiechen>

Component:

CSS

Assignee:

cathiechen <cathiechen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cathiechen, clopez, ews-watchlist, fujii.hironori, rbuis, stephan.szabo, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

172026

Attachments:

Description	Flags
import-css-contain-test	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

cathiechen

Reported 2021-03-16 08:10:37 PDT

Import the WPT test of CSS property contain.

Attachments
import-css-contain-test (933.24 KB, patch) 2021-03-16 08:20 PDT, cathiechen	no flags	Details Formatted Diff Diff
Patch (1.06 MB, patch) 2021-03-16 10:23 PDT, cathiechen	no flags	Details Formatted Diff Diff
Patch (1.07 MB, patch) 2021-03-17 00:19 PDT, cathiechen	no flags	Details Formatted Diff Diff
Patch (1.07 MB, patch) 2021-03-17 00:23 PDT, cathiechen	no flags	Details Formatted Diff Diff
Patch (1.07 MB, patch) 2021-03-17 00:48 PDT, cathiechen	no flags	Details Formatted Diff Diff
Patch (1.08 MB, patch) 2021-03-17 01:42 PDT, cathiechen	no flags	Details Formatted Diff Diff
Patch (1.09 MB, patch) 2021-03-17 02:39 PDT, cathiechen	no flags	Details Formatted Diff Diff
Patch (1.09 MB, patch) 2021-03-17 04:49 PDT, cathiechen	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

cathiechen

Comment 1 2021-03-16 08:20:14 PDT

Created attachment 423332 [details] import-css-contain-test

cathiechen

Comment 2 2021-03-16 10:23:27 PDT

Created attachment 423351 [details] Patch

cathiechen

Comment 3 2021-03-17 00:19:21 PDT

Created attachment 423441 [details] Patch

cathiechen

Comment 4 2021-03-17 00:23:22 PDT

Created attachment 423442 [details] Patch

cathiechen

Comment 5 2021-03-17 00:48:54 PDT

Created attachment 423445 [details] Patch

Rob Buis

Comment 6 2021-03-17 01:29:08 PDT

Comment on attachment 423445 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423445&action=review > LayoutTests/imported/w3c/ChangeLog:7 Can you mention the exact SHA this based on?

cathiechen

Comment 7 2021-03-17 01:37:20 PDT

Comment on attachment 423445 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423445&action=review >> LayoutTests/imported/w3c/ChangeLog:7 >> + > > Can you mention the exact SHA this based on? I think 868fe4c01aef5e27fedc51ea7d938cf556cffec2 is the SHA.

cathiechen

Comment 8 2021-03-17 01:42:44 PDT

Created attachment 423455 [details] Patch

cathiechen

Comment 9 2021-03-17 02:39:29 PDT

Created attachment 423458 [details] Patch

Rob Buis

Comment 10 2021-03-17 04:02:42 PDT

Comment on attachment 423458 [details] Patch Looks good, not sure if we need help regarding the wincairo bot problem.

cathiechen

Comment 11 2021-03-17 04:49:26 PDT

Created attachment 423471 [details] Patch

cathiechen

Comment 12 2021-03-17 04:55:56 PDT

Hi Fujii Hironori, It looks like wincairo build bot does not clean up the image somehow. We got an error to apply the patch. Would you please take a look at this ? Thanks:) > LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/resources/dice.png already exists at Tools/Scripts/svn-apply line 281.

Fujii Hironori

Comment 13 2021-03-17 13:07:48 PDT

I didn't know that problem. Thank you for letting me know. However, this seems a EWS specific issue. Feel free to land your patch.

Stephan Szabo

Comment 14 2021-03-17 13:47:13 PDT

I cleared the directory manually and on rebuild it seemed to pass on the wincairo ews.

cathiechen

Comment 15 2021-03-17 17:29:59 PDT

Thanks, Fujii and Stephan!

EWS

Comment 16 2021-03-18 00:44:17 PDT

Committed r274620: <https://commits.webkit.org/r274620> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423471 [details].

Radar WebKit Bug Importer

Comment 17 2021-03-18 00:45:19 PDT

<rdar://problem/75563636>

Note You need to log in before you can comment on or make changes to this bug.